Repository navigation
Consolidate generateRefId into @corbits/error-sink - #533
Merged
Merged
Conversation
@workbench/hub-client re-exports it instead of keeping a byte-for-byte duplicate. Same output format, so no caller-visible refId change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@workbench/hub-client'sgenerateRefId(error-envelope.ts) and@corbits/error-sink'sgenerateRefId(ref-id.ts) were byte-for-byte identical. Confirmed by direct diff, not by memory.@intx/hub-common'sgenerateIdfirst per AGENTS.md before reimplementing anything: it mints{prefix}_{32 hex chars}for a fixed set of entity kinds (tenant, principal, session, ...), not a short human-quotable support refId — it doesn't cover this shape, so this isn't a case of an unnecessary reimplementation of a native primitive.@corbits/error-sinkalready owned the convention (per its own module comment, creditingpackages/onboarding/src/routes.tsas the pattern it generalized), so it keeps the sole implementation;@workbench/hub-clientnow re-exports it instead of keeping a duplicate. No circular dependency:@corbits/error-sinkonly depends on@intx/logandarktype.${Date.now().toString(36)}-${random}) is unchanged, so no caller-visible refId format change.principal.refIdfield elsewhere in the codebase is an unrelated concept (an auth-user identity), not this primitive.Test plan
bun run typecheckHUB_DATA_DIR=$(mktemp -d) bun test packages/hub-client packages/error-sink— 202 passbunx prettier --checkon touched filesbun run check:structural(pre-existingcheck:report-errorbaseline violations only, unrelated to this change)