Skip to content

build: add eslint config and lint script - #14

Merged
TheGreatAxios merged 2 commits into
cl-9190-reranking-replace-hand-rolled-fetch-fake-with-intxinferencefrom
cl-9320-reranking-add-eslint-config-and-lint-script
Sep 27, 2026
Merged

TheGreatAxios merged 2 commits into
cl-9190-reranking-replace-hand-rolled-fetch-fake-with-intxinferencefrom
cl-9320-reranking-add-eslint-config-and-lint-script

Conversation

@TheGreatAxios

@TheGreatAxios TheGreatAxios commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Stacked on test: drive tests through @intx/inference-testing, add TEI e2e suite #11, so the rewritten tests are linted too.
  • Adds eslint.config.ts, identical to corbits-ollama-adapter's, with eslint 10.10.0, @eslint/js 10.0.1, typescript-eslint 8.69.0 and jiti 2.7.0.
  • Adds a lint script and a CI lint step; CI runs bunx prettier --check . over the whole repo.
  • Fixes the existing findings: Array<T> becomes T[], and test error casts become toMatchObject/toHaveProperty assertions.

Verification

  • bun install --frozen-lockfile, bun run lint, bunx tsc --noEmit, bun test ./src, bunx prettier --check ., bun run build pass.

Closes CL-9320

@TheGreatAxios TheGreatAxios left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-review: independent critique pass found no blocking issues; diff matches the ticket outcome. Checks listed under Verification pass.

@TheGreatAxios
TheGreatAxios force-pushed the cl-9320-reranking-add-eslint-config-and-lint-script branch from 22f95cf to 51451ab Compare September 25, 2026 13:55
@TheGreatAxios
TheGreatAxios force-pushed the cl-9320-reranking-add-eslint-config-and-lint-script branch 2 times, most recently from c416594 to 0216117 Compare September 25, 2026 14:12
@TheGreatAxios
TheGreatAxios force-pushed the cl-9320-reranking-add-eslint-config-and-lint-script branch from 0216117 to 6ce9541 Compare September 25, 2026 14:16
@TheGreatAxios
TheGreatAxios force-pushed the cl-9320-reranking-add-eslint-config-and-lint-script branch from 6ce9541 to 6365240 Compare September 25, 2026 17:32
@TheGreatAxios TheGreatAxios changed the title Add eslint config and lint script Add eslint config and lint script, check formatting repo-wide Sep 25, 2026
@TheGreatAxios
TheGreatAxios force-pushed the cl-9320-reranking-add-eslint-config-and-lint-script branch from 6365240 to ca730dc Compare September 26, 2026 01:30
eslint.config.ts matches corbits-ollama-adapter, with eslint,
@eslint/js, typescript-eslint and jiti at the same versions. CI runs
bun run lint. Existing findings (array-type, unsafe test casts) fixed.
@TheGreatAxios
TheGreatAxios force-pushed the cl-9320-reranking-add-eslint-config-and-lint-script branch from ca730dc to e24f315 Compare September 26, 2026 01:30
@TheGreatAxios TheGreatAxios changed the title Add eslint config and lint script, check formatting repo-wide build: add eslint config and lint script Sep 26, 2026
@TheGreatAxios
TheGreatAxios added this pull request to stack #15 September 26, 2026 01:59
@TheGreatAxios

Copy link
Copy Markdown
Contributor Author

Superseded: oxfmt and oxlint replace ESLint and Prettier in this repo.

@TheGreatAxios

Copy link
Copy Markdown
Contributor Author

Reopened only so the stack merges in order: later PRs are built on this branch. The oxfmt/oxlint PR higher in the stack removes this ESLint setup, so main ends up with oxc only.

@TheGreatAxios
TheGreatAxios merged commit e4d07f7 into main Sep 27, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant