Skip to content

docs: keep README to the seam; persist narrative moves to CONTRIBUTING - #41

Merged
TheGreatAxios merged 1 commit into
cl-9239-mailbox-align-runmailboxmigrations-to-runmigrationsconfigfrom
cl-9216-mailbox-remove-readme-prose-that-repeats-the-options-table
Sep 27, 2026
Merged

TheGreatAxios merged 1 commit into
cl-9239-mailbox-align-runmailboxmigrations-to-runmigrationsconfigfrom
cl-9216-mailbox-remove-readme-prose-that-repeats-the-options-table

Conversation

@TheGreatAxios

@TheGreatAxios TheGreatAxios commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Stacked on feat(migrations)!: runMailboxMigrations(config, { schema }) #40.
  • The README's agent-originated mail section keeps one line each for authorizeSender and upstream. The narrative on how the two writes interact moves to CONTRIBUTING.
  • The README has no prose repeating the options table.
  • Source comments describe current behavior only.

Verification

CI is green on this branch: install --frozen-lockfile, build, typecheck, tests against Postgres, and the Node consumer smoke test.

Closes CL-9216
Closes CL-9220
Closes CL-9238

@TheGreatAxios TheGreatAxios left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-review: an independent review pass covered this branch, and every finding is fixed. Build, typecheck and tests pass against real Postgres.

@TheGreatAxios
TheGreatAxios force-pushed the cl-9216-mailbox-remove-readme-prose-that-repeats-the-options-table branch 2 times, most recently from 7337223 to 687f2e7 Compare September 25, 2026 17:52
@TheGreatAxios
TheGreatAxios force-pushed the cl-9216-mailbox-remove-readme-prose-that-repeats-the-options-table branch from 687f2e7 to 260e0bb Compare September 26, 2026 01:28
@TheGreatAxios
TheGreatAxios added this pull request to stack #47 September 26, 2026 01:58
The README says what authorizeSender and upstream are; how the two
writes interact is contributor material. Source comments describe
current behavior only.

Closes CL-9216, CL-9220, CL-9238.
@TheGreatAxios
TheGreatAxios force-pushed the cl-9216-mailbox-remove-readme-prose-that-repeats-the-options-table branch from 260e0bb to 37fbce9 Compare September 26, 2026 02:40
@TheGreatAxios
TheGreatAxios removed this pull request from stack #47 September 26, 2026 02:40
@TheGreatAxios
TheGreatAxios added this pull request to stack #50 September 26, 2026 02:40
@TheGreatAxios
TheGreatAxios merged commit 6ee8910 into main Sep 27, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant