feat(migrations)!: runMailboxMigrations(config, { schema }) - #40
Merged
TheGreatAxios merged 1 commit intoSep 27, 2026
Conversation
TheGreatAxios
commented
Sep 25, 2026
TheGreatAxios
left a comment
TheGreatAxios
left a comment
Contributor
Author
There was a problem hiding this comment.
Self-review: an independent review pass found no correctness bugs; its doc and public-surface findings are fixed (stale JSDoc, createMailboxDb export dropped, wrapping, FK-move note). Build, typecheck and 173 tests pass.
TheGreatAxios
force-pushed
the
cl-9239-mailbox-align-runmailboxmigrations-to-runmigrationsconfig
branch
from
September 25, 2026 15:02
eace332 to
a9a2a77
Compare
TheGreatAxios
force-pushed
the
cl-9239-mailbox-align-runmailboxmigrations-to-runmigrationsconfig
branch
from
September 25, 2026 17:52
a9a2a77 to
0b6b844
Compare
TheGreatAxios
force-pushed
the
cl-9239-mailbox-align-runmailboxmigrations-to-runmigrationsconfig
branch
from
September 26, 2026 01:28
0b6b844 to
899ea82
Compare
TheGreatAxios
changed the title
TheGreatAxios
added this pull request to stack #47
September 26, 2026 01:58
The runner takes the same arguments a host passes Interchange's runMigrations: a DBConfig and the host schema holding tenant and principal. The mailbox FKs point at that schema; the mailbox tables stay in the mailbox schema, and ledger checksums hash the statements as shipped so they do not depend on the host schema. createMailboxDb is no longer exported; it moves into the test helpers. Closes CL-9239.
TheGreatAxios
force-pushed
the
cl-9239-mailbox-align-runmailboxmigrations-to-runmigrationsconfig
branch
from
September 26, 2026 02:40
899ea82 to
13dbe3d
Compare
TheGreatAxios
removed this pull request from stack #47
September 26, 2026 02:40
TheGreatAxios
added this pull request to stack #50
September 26, 2026 02:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
runMailboxMigrations(config: DBConfig, { schema })takes the same arguments as Interchange'srunMigrations; the(db)signature is removed.schemais the host schema holdingtenant/principal; the mailbox FKs are rewritten to it. Mailbox tables stay in themailboxschema. Same convention as corbits-cron.@intx/db^0.4.0is a new peer;createMailboxDbis no longer exported. README quickstart usescreateDBand passesschema: "public".Verification
A new test migrates into a non-public host schema and asserts the FKs target it; another rejects an empty schema. The README quickstart compiles under
tsc --strict. CI is green on this branch: install--frozen-lockfile, build, typecheck, tests against Postgres, and the Node consumer smoke test.Closes CL-9239