fix: retry per-attempt timeouts and validate vector dimensions - #18
Merged
TheGreatAxios merged 1 commit intoSep 27, 2026
Conversation
A per-attempt timeout is now classified as timeout, which the default policy retries; a caller abort stays aborted. Empty vectors, uneven lengths within a call, and lengths other than config.dimensions throw EmbeddingRequestError with protocol_mismatch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
timeoutMsexpiry is classified astimeout, which the default retry policy retries; a callersignalabort is stillabortedand not retried.embedTextsrejects empty vectors, vectors whose length differs from the first in the same call (across batches), and vectors whose length differs fromconfig.dimensionswhen set. Each throwsEmbeddingRequestErrorwithprotocol_mismatch.timeoutMsanddimensionsrows and the Dimensions section describe the new behavior.Verification
bun run check,bun run build: passbun run test:e2ewithEMBEDDING_E2E_BASE_URL=http://100.113.184.123:11434/v1: 12 pass, 0 fail (live included)timeout; caller abort staysaborted; empty, uneven and off-dimension vectors) failed before the fix, except the caller-abort guardCloses CL-9445