Skip to content

fix: cap Retry-After at 60 seconds and trim trailing slashes from baseURL - #19

Merged
TheGreatAxios merged 1 commit into
cl-9445-embedding-retry-per-attempt-timeouts-and-validate-vectorfrom
cl-9446-embedding-cap-retry-after-and-trim-trailing-slash-on-baseurl
Sep 27, 2026
Merged

TheGreatAxios merged 1 commit into
cl-9445-embedding-retry-per-attempt-timeouts-and-validate-vectorfrom
cl-9446-embedding-cap-retry-after-and-trim-trailing-slash-on-baseurl

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Contributor

Summary

  • The default extractRetryAfterMs clamps both seconds and HTTP-date Retry-After to [0, 60s], so retry-after: 86400 waits one minute, not a day.
  • Trailing slashes on baseURL are trimmed, so http://host/v1/ posts to /v1/embeddings, not /v1//embeddings.
  • README notes both.
  • Stacked on fix: retry per-attempt timeouts and validate vector dimensions #18.

Verification

  • bun run check, bun run build: pass
  • bun run test:e2e with EMBEDDING_E2E_BASE_URL=http://100.113.184.123:11434/v1/: 14 pass, 0 fail (live included)
  • New tests (86400s Retry-After waits 60s; baseURL ending in // hits /v1/embeddings) failed before the fix
  • Node pack smoke: pass

Closes CL-9446

@TheGreatAxios
TheGreatAxios added this pull request to stack #15 September 27, 2026 01:14
@TheGreatAxios
TheGreatAxios merged commit df54e86 into main Sep 27, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant