Skip to content

Fix the router for request URIs starting with double slashes #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Toflar merged 2 commits into from
Oct 3, 2026
Merged

Fix the router for request URIs starting with double slashes #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
009fc5e
Add a regression test for local app servers running with double slash…
zoglo Oct 3, 2026
e5c24aa
Fix the router for requests with double slashes
zoglo Oct 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion e2e-testing/src/Http/PhpRouter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public static function generate(string $index, string $prelude = ''): string

$prelude

\$path = rawurldecode(parse_url(\$_SERVER['REQUEST_URI'], PHP_URL_PATH) ?? '/');
\$path = rawurldecode((string) parse_url(\$_SERVER['REQUEST_URI'], PHP_URL_PATH) ?: '/');

if ('/' !== \$path && is_file(\$_SERVER['DOCUMENT_ROOT'].\$path)) {
return false;
Expand Down
13 changes: 13 additions & 0 deletions e2e-testing/tests/LocalApplicationServerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,19 @@ public function testPhpServerHandlesFrontControllerRoutesAndStaticFilesAndStops(
$this->assertStopped($server->baseUri);
}

public function testPhpServerPassesDoubleSlashRequestsToTheFrontController(): void
{
$server = (new WebServerManager())->start(WebServerConfig::php($this->directory));

try {
$response = HttpClient::create()->request('GET', $server->baseUri.'//');
$this->assertSame(200, $response->getStatusCode());
$this->assertSame('//', $response->toArray()['uri']);
} finally {
$server->stop();
}
}

public function testServerLoggingCannotBlockRequests(): void
{
(new Filesystem())->dumpFile($this->directory.'/public/index.php', '<?php error_log(str_repeat("x", 8192)); echo "OK";');
Expand Down
Loading