Skip to content

Fix the router for request URIs starting with double slashes - #9

Merged
Toflar merged 2 commits into
contao:mainfrom
zoglo:fix/local-app-servers
Oct 3, 2026
Merged

Toflar merged 2 commits into
contao:mainfrom
zoglo:fix/local-app-servers

Conversation

@zoglo

@zoglo zoglo commented Oct 3, 2026 •

Copy link
Copy Markdown
Member

Description

Fixes the failing E2E test as seen here https://github.com/contao/contao/actions/runs/37078047354/job/111072215440 in contao/contao#10400.

For the //, parse_url() returns false, which crashes the router with a 500 before Contao can get the request in the E2E test.

As always, first commit for the failing regression test -> https://github.com/contao/setup-and-testing/actions/runs/37081299810/job/111082191540

@zoglo

zoglo commented Oct 3, 2026

Copy link
Copy Markdown
Member Author

Using ?: '/' handles both null and false from parse_url() which will make sure that double slashes fall back to /.

@zoglo

zoglo commented Oct 3, 2026

Copy link
Copy Markdown
Member Author

/cc @Toflar =)

@Toflar
Toflar merged commit 7804ed6 into contao:main Oct 3, 2026
6 checks passed
@zoglo
zoglo deleted the fix/local-app-servers branch October 3, 2026 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants