Fail fast and document downloads on Android 9 and older - #75
Merged
Merged
Conversation
On API 28 and older, inserting into MediaStore's shared Pictures collection needs WRITE_EXTERNAL_STORAGE. The plugin does not declare it on purpose, so downloadWallpaper downloaded the whole image and then failed with a SecurityException. It now checks the permission first, logs why it failed, and returns false without downloading. The README and Android guide say what a host app supporting those versions must declare and request. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Android 9 and older, inserting into the shared Pictures collection needs
WRITE_EXTERNAL_STORAGE. The plugin deliberately does not declare it, sodownloadWallpaperdownloaded the whole image and then failed withSecurityException: Permission Denial.The README and the Android guide now say what an app that supports those versions must declare (
maxSdkVersion="28") and request at runtime. The plugin's own manifest is unchanged.Verification
On an API 26 emulator:
Local CI (format, analyze, tests, pigeon check, Gradle test/lint/assemble, iOS simulator build): pass.
🤖 Generated with Claude Code