Fix double apply, cache loss, and hidden failures on rotation start - #74
Merged
Merged
Conversation
- Start applied the first wallpaper, and WorkManager then ran the new periodic request at once, so a second wallpaper was applied and the playlist skipped ahead. The periodic and charging requests now wait one interval before their first run. - prepareLocalFiles deleted the cache before it knew whether any new source would load. A rejected start therefore wiped the files of the rotation that was still running, and every later rotation failed. New sources now go into a staging directory that replaces the cache only when at least one source loaded. - totalCount and cachedCount were both the number of cached files, so a source that failed to load was invisible. totalCount now reports the requested sources. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three rotation-start bugs, all reproduced on an API 36 emulator:
Verification
API 36 emulator, checked with
dumpsys wallpaperids and logcat:wallpaper_0.jpgandwallpaper_1.jpgsurvive, and Rotate now succeeds.Tests: JVM tests cover the staging swap (a reject keeps the cache, an accept replaces it) and the WorkManager initial delay. Plugin unit tests: 63 pass.
Local CI (format, analyze, tests, pigeon check, Gradle test/lint/assemble, iOS simulator build): pass.
🤖 Generated with Claude Code