Report unreadable cropper sources with the loader's error codes - #72
Merged
Merged
Conversation
Android resolves the crop-and-set intent by the URI's MIME type. For a content URI that no longer exists, getType returns null, the lookup fails, and getCropAndSetWallpaperIntent throws. The plugin reported that as a generic system-ui-failed. It now checks the type first and returns source-unavailable or invalid-content-type, as the direct path does. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
systemCroppergot a content URI that no longer exists, it returnedfailed — system-ui-failed — Unable to open the wallpaper cropper.Android resolves the crop intent by the URI's MIME type.getTypereturns null for a missing row, the intent lookup finds nothing, andgetCropAndSetWallpaperIntentthrows.These are the same codes the direct path already uses for the same URI.
Verification
content://media/external/images/media/1(missing) →failed — source-unavailable — The content URI could not be read., with the same result for Home and Lock.WallpaperCropActivity→previewOpened.🤖 Generated with Claude Code