Skip to content

Read module descriptors without ASM #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
slachiewicz wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Read module descriptors without ASM #242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83e2b7d
Read module descriptors without ASM
slachiewicz Sep 26, 2026
006a0c1
Build on JDK 26, 27 and 28-ea
slachiewicz Sep 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/maven.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,13 @@ jobs:
build:
name: Build it
uses: codehaus-plexus/.github/.github/workflows/maven.yml@master
with:
matrix-include: >
[
{ "os": "ubuntu-latest", "jdk": "26", "distribution": "zulu" },
{ "os": "ubuntu-latest", "jdk": "27", "distribution": "zulu" },
{ "os": "ubuntu-latest", "jdk": "28-ea", "distribution": "temurin" }
]

# deploy:
# name: Deploy
Expand Down
5 changes: 0 additions & 5 deletions plexus-java/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,6 @@
<name>Plexus Languages :: Java</name>

<dependencies>
<dependency>
<groupId>org.ow2.asm</groupId>
<artifactId>asm</artifactId>
<version>9.10.1</version>
</dependency>
<dependency>
<groupId>com.github.javaparser</groupId>
<artifactId>javaparser-core</artifactId>
Expand Down
137 changes: 0 additions & 137 deletions plexus-java/src/main/java/org/codehaus/plexus/languages/java/jpms/AsmModuleInfoParser.java
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion ...us-java/src/main/java/org/codehaus/plexus/languages/java/jpms/BinaryModuleInfoParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@
* specific language governing permissions and limitations
* under the License.
*/
class BinaryModuleInfoParser extends AsmModuleInfoParser {}
class BinaryModuleInfoParser extends ModuleInfoClassParser {}
6 changes: 4 additions & 2 deletions plexus-java/src/main/java/org/codehaus/plexus/languages/java/jpms/LocationManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,9 @@ public <T> ResolvePathsResult<T> resolvePaths(final ResolvePathsRequest<T> reque

/**
* If the jdkHome is specified, its version it considered higher than the runtime java version.
* In that case ASM must be used to read the module descriptor
* In that case the version-agnostic {@link ModuleInfoClassParser} must be used to read the module
* descriptor, since the runtime's own {@code java.lang.module.ModuleDescriptor} cannot be trusted
* to read a module-info.class produced by a newer JDK than the one it runs on.
*
* @param jdkHome
* @return
Expand All @@ -289,7 +291,7 @@ ModuleInfoParser getBinaryModuleInfoParser(final Path jdkHome) {
if (jdkHome == null) {
binaryParser = new BinaryModuleInfoParser();
} else {
binaryParser = new AsmModuleInfoParser();
binaryParser = new ModuleInfoClassParser();
}
return binaryParser;
}
Expand Down
Loading
Loading