Read module descriptors without ASM - #242
Draft
slachiewicz wants to merge 2 commits into
Draft
slachiewicz wants to merge 2 commits into
slachiewicz wants to merge 2 commits into
Conversation
Spotless is skipped on JDK 27+ until palantir-java-format runs there (palantir/palantir-java-format#1785); drop the profile once it does.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces
AsmModuleInfoParserwith a reader of theModuleattribute (JVMS 4.7.25) and drops theorg.ow2.asmdependency andrequires org.objectweb.asm. The reader does not check the class file version, so amodule-info.classfrom any future JDK parses without a library release; the only thing that could break it is a new constant pool tag.One of two alternatives for #165, for comparison with #244, which keeps ASM and adds a Java 24 Class File API layer. A side-by-side test against ASM gave identical descriptors for all 8
module-info.classfiles and jar entries undersrc/test/test-data; that test is not part of this PR.Main code: +302 / −137 lines. The java9
ModuleDescriptor.readparser is unchanged.Includes the CI commit from #243 so the JDK 26, 27 and 28-ea legs exercise the reader.