test: cover DynamoDB table provisioning schema - #315
Merged
codeforstartups merged 1 commit intoOct 2, 2026
Merged
codeforstartups merged 1 commit into
codeforstartups merged 1 commit into
Conversation
3 tasks
Kaap10
approved these changes
Oct 2, 2026
Kaap10
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the contribution, @tikhandesanket! Great to see test coverage added for ensure_table().
The test is clean and correctly validates the table's KeySchema and AttributeDefinitions using Moto.
A couple of minor suggestions:
- Idempotency:
ensure_table()is designed to be idempotent (handlingResourceInUseException). Callingensure_table(config, session)a second time in the test would help verify this contract. - Convention: Please add
from __future__ import annotationsat the top of the file to align with the rest of the codebase.
LGTM!
Owner
|
Clean, focused test — verifies |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add test coverage for DynamoDB table provisioning to verify that
ensure_table()creates the expected key schema.Related issue
Fixes #
Changes
pkas the HASH/partition key.pkis defined as a DynamoDB String (S).Testing
Checklist