DO NOT MERGE: validate dev-registry reconcile fix on Windows - #15038
Closed
petebacondarwin wants to merge 2 commits into
Closed
DO NOT MERGE: validate dev-registry reconcile fix on Windows#15038petebacondarwin wants to merge 2 commits into
petebacondarwin wants to merge 2 commits into
Conversation
…creating them Applying options called `unregisterWorkers()` unconditionally, unlinking every entry this instance had registered, before `register()` wrote them all back. Peers discover Workers by watching that directory, so every config update published a window in which this session appeared to have no Workers at all. `updateRegistryPath()` now only clears entries when the registry path actually changes, since those entries live in the directory being left behind, and `register()` reconciles the set: retained Workers are overwritten in place and only genuinely removed ones are unlinked.
🦋 Changeset detectedLatest commit: dcaf775 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
UnknownError: ProviderInitError |
Contributor
|
@petebacondarwin Bonk workflow failed. Check the logs for details. View workflow run · To retry, trigger Bonk again. |
Contributor
|
✅ All changesets look good |
@cloudflare/autoconfig
@cloudflare/build-output-utils
@cloudflare/config
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-functions
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
5 tasks
This was referenced Aug 5, 2026
5 tasks
Contributor
Author
|
Closing: measurement done, result recorded on #15037. With the reconcile fix in place the un-skipped Windows suite still produced 23 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary validation harness for #15037. Not for merge.
Lifts #15018's Windows skip on
fixtures/dev-registry, repeats thevite dev <-> vite devsuite four times, dumps every session's output (not only failed ones) with a capture timestamp, reportsCRASH-DETECTEDper session, isolates the fixture in the workflow and raises the job timeout.Will be closed once #15037 is measured.
Note
This is a contribution from an AI agent: OpenCode, claude-opus-5.