DO NOT MERGE: validate dev registry registration fix on Windows - #15041
DO NOT MERGE: validate dev registry registration fix on Windows#15041edmundhung wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 544d014 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
|
✅ All changesets look good |
|
vitest-pool-workers doesn't use the dev registry, so no change needed there. All internal consumers that need registration have been updated (wrangler dev, wrangler platform integration, vite dev, vite preview). I've completed a thorough review. Summary of findings:
The only "issues" are the intentional DO-NOT-MERGE scaffolding (60min timeout, isolated fixture filter, 4x loop, lifted Windows skip), which the author has explicitly flagged as temporary and states will be closed rather than merged. Flagging these would be redundant with the author's own clearly-stated intent, and there are no concrete fixes to suggest for a deliberate throwaway harness. No actionable code issues. LGTM |
@cloudflare/autoconfig
@cloudflare/build-output-utils
@cloudflare/config
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-functions
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
|
Validation result: this does not fix the Windows flake, so #15040 should be judged as the internal-worker collision/churn fix for #15035 only. I reused #15038's harness unchanged in #15041 and ran the
Job: https://github.com/cloudflare/workers-sdk/actions/runs/31017919389/job/92346768939 The difference in raw abort count is too small and noisy to indicate an improvement; the abort remains readily reproducible after the internal registry entries are removed. #15018's Windows skip needs to stay. This rules out the fixed-name internal-worker collisions as the sole trigger, while #15040 still removes those accidental entries and the cross-session registry traffic they cause. |
Temporary validation harness for #15040, addressing #15035. Not for merge.
This reuses #15038's harness so the result is directly comparable with Pete's validation of #15037. It lifts #15018's Windows skip on
fixtures/dev-registry, repeats thevite dev <-> vite devsuite four times, dumps every session's timestamped output, reportsCRASH-DETECTEDper session, isolates the fixture in the workflow, and raises the job timeout.This PR should be closed once the Windows result has been measured and recorded on #15040.