add sqlite/mysql/postgresql support to ocspserve cli#757
add sqlite/mysql/postgresql support to ocspserve cli#757bjt79 wants to merge 23 commits intocloudflare:masterfrom
Conversation
| } | ||
| if !sctEquals(zeroSCT, lst[0]) { | ||
| t.Fatal("SCTs don't match") | ||
|
|
There was a problem hiding this comment.
some old code get erased (merged) here.
| default: | ||
| return nil, fmt.Errorf("multiple prefixes: %s", | ||
| strings.Join(splitVal[:len(splitVal)-1], ", ")) | ||
|
|
There was a problem hiding this comment.
some old code get erased (merged) here.
kisom
left a comment
kisom
left a comment
There was a problem hiding this comment.
The merge conflicts and test failures still need to be sorted out, too.
| // which can either be a file or the path to a DB (Sqlite, MySQL or PostgreSQL). | ||
| // It returns the type of the connection string (e.g. "File" or "MySQL" etc.) as | ||
| // well as the path to the source. | ||
| func ParseConnectionStr(conn string) (string, string, error) { |
There was a problem hiding this comment.
This should be ParseConnString (or NewSourceFromConnString should be renamed NewSourceFromConnectionString).
| // argument, and this function currently supports Sqlite, MySQL and PostgreSQL. | ||
| // The dbpath argument is a connection string aiding in connecting to the | ||
| // associated DB type. | ||
| func NewSourceFromConnStr(typ, dbpath string) (Source, error) { |
There was a problem hiding this comment.
This should be NewSourceFromConnString.
Codecov Report
@@ Coverage Diff @@
## master #757 +/- ##
==========================================
+ Coverage 57.67% 57.72% +0.04%
==========================================
Files 78 75 -3
Lines 6922 6904 -18
==========================================
- Hits 3992 3985 -7
+ Misses 2513 2506 -7
+ Partials 417 413 -4
Continue to review full report at Codecov.
|
4 participants
No description provided.