Added option to provide db config to ocsp serve#825
Conversation
johanneslanger
force-pushed
the
master
branch
from
11abd5e to
b1a5b7c
Compare
kisom
left a comment
kisom
left a comment
There was a problem hiding this comment.
Overall looks good, just two very small things to fix.
| return src, nil | ||
| } | ||
|
|
||
| func NewSourceFromDB(DBConfigFile string) (Source, error) { |
There was a problem hiding this comment.
This needs a comment (it's what's causing the build to fail right now).
| var ocspServerUsageText = `cfssl ocspserve -- set up an HTTP server that handles OCSP requests from a file (see RFC 5019) | ||
|
|
||
| var ocspServerUsageText = `cfssl ocspserve -- Setup an HTTP server that handles OCSP requests from either a file or directly from a database (see RFC 5019) | ||
There was a problem hiding this comment.
You probably didn't mean for this whitespace to go in.
johanneslanger
force-pushed
the
master
branch
2 times, most recently
from
7422703 to
33e211e
Compare
johanneslanger
force-pushed
the
master
branch
from
33e211e to
2421a4a
Compare
Codecov Report
@@ Coverage Diff @@
## master #825 +/- ##
==========================================
+ Coverage 56.17% 56.19% +0.02%
==========================================
Files 76 76
Lines 8572 8583 +11
==========================================
+ Hits 4815 4823 +8
- Misses 3332 3334 +2
- Partials 425 426 +1
Continue to review full report at Codecov.
|
|
Thanks for the feedback. I've updated accordingly. |
|
@johanneslanger it's a known issue with the Travis OS X builds. |
3 participants
Hi,
this is to provide the option to specify a db config file for the ocsp serve cli tool. As the existing pull request #757 didn't seem to get updated. This should implement feature request #738.
Please have look and let me know what you think!