Skip to content

Group VMware worker export options under export mechanism #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mihaelabalutoiu wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Group VMware worker export options under export mechanism #945

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cf64d25
Group VMware worker export options under export mechanism
mihaelabalutoiu Sep 28, 2026
89b98e7
Fix grouping of already grouped `migr_` fields as worker options
mihaelabalutoiu Sep 28, 2026
76b16cf
Fix option group names ignoring schema titles
mihaelabalutoiu Sep 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/modules/WizardModule/WizardOptions/WizardOptions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,7 @@ class WizardOptions extends React.Component<Props> {
let groups: Array<{ fields: FieldRender[]; name?: string }> = [{ fields }];

const workerFields = fields.filter(
f => f.field.name.indexOf("migr_") === 0,
f => f.field.name.indexOf("migr_") === 0 && !f.field.groupName,
);
if (workerFields.length > 1) {
groups = [
Expand Down Expand Up @@ -594,7 +594,7 @@ class WizardOptions extends React.Component<Props> {
<GroupName>
<GroupNameBar />
<GroupNameText>
{LabelDictionary.get(g.name)}
{LabelDictionary.get(g.name, this.props.dictionaryKey)}
</GroupNameText>
<GroupNameBar />
</GroupName>
Expand Down
32 changes: 32 additions & 0 deletions src/plugins/vmware_vsphere/OptionsSchemaPlugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,31 @@ export default class OptionsSchemaParser extends OptionsSchemaPluginBase {
];
});

const exportMechField = fields.find(
f => f.name === "export_transfer_mechanism",
);
if (!exportMechField?.enum) {
return fields;
}
exportMechField.subFields = [];
exportMechField.enum.forEach((exportType: any) => {
const exportTypeFieldIdx = fields.findIndex(
f => f.name === `${exportType}_options`,
);
if (exportTypeFieldIdx === -1) {
return;
}
const subField = fields[exportTypeFieldIdx];
if (subField.properties?.length) {
subField.properties = subField.properties.map((p: Field) => ({
...p,
groupName: subField.name,
}));
}
exportMechField.subFields!.push(subField);
fields.splice(exportTypeFieldIdx, 1);
});

return fields;
}

Expand All @@ -68,6 +93,13 @@ export default class OptionsSchemaParser extends OptionsSchemaPluginBase {
requiresWindowsImage: boolean;
}) {
const { field, options, requiresWindowsImage } = opts;
if (field.name === "export_transfer_mechanism" && field.subFields) {
field.subFields.forEach(sf => {
sf.properties?.forEach(f => {
super.fillFieldValues({ field: f, options, requiresWindowsImage });
});
});
}

const option = options.find(f => f.name === field.name);
if (!option) {
Expand Down
Loading