Skip to content

Group VMware worker export options under export mechanism - #945

Open
mihaelabalutoiu wants to merge 3 commits into
cloudbase:mainfrom
mihaelabalutoiu:add-worker-export-options
Open

mihaelabalutoiu wants to merge 3 commits into
cloudbase:mainfrom
mihaelabalutoiu:add-worker-export-options

Conversation

@mihaelabalutoiu

Copy link
Copy Markdown
Member

This PR has the following changes:

  • Groups VMware worker export options under the export mechanism;
  • Fixes the grouped migr_minion_* fields being displayed twice, by skipping fields with a groupName when building the Temporary Migration Worker Options group;
  • Fixes group names ignoring schema titles by passing the dictionary key to the label lookup.

The VMware source environment schema now groups the options of the
`worker` export transfer mechanism under a `worker_options` object.

Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
The grouped `worker_options` fields were also added to the `Temporary
Migration Worker Options` group because of their `migr_` prefix, so
they were displayed twice. Skip fields which already have a
`groupName` when building that group.

Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
The group names were looked up without the dictionary key, so the
schema titles were never found and the labels were generated from the
field names instead.

Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants