Skip to content

fix(consensus): open the store only after the execution engine is reachable #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ZanCorDX wants to merge 1 commit into from
+7 −5
Closed

fix(consensus): open the store only after the execution engine is reachable #465

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions crates/malachite-app/src/node.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -781,11 +781,6 @@ impl App {
// Setup metrics
let (app_metrics, db_metrics, process_metrics) = self.setup_metrics();

// Open the store
let (store, store_monitor) = self
.open_store(db_metrics, env_config.db_cache_size)
.await?;

// Connect to the execution engine and resolve consensus spec and genesis
// hash. The EL may be restarting underneath us, so retry with a fresh
// connection until it serves or the startup deadline elapses.
Expand Down Expand Up @@ -854,6 +849,13 @@ impl App {
#[cfg(not(feature = "byzantine"))]
let state_ctx = ctx;

// Open the store only after the execution engine is reachable: a startup failure
// before this point must not leave the store without a quick-repair commit, which
// would force a full database repair on the next start.
let (store, store_monitor) = self
.open_store(db_metrics, env_config.db_cache_size)
.await?;

// Initialize the application state with the resolved spec and genesis block.
let mut state = State::builder(state_ctx)
.identity(identity.consensus.clone())
Expand Down
Loading