Conversation
ZanCorDX
requested review from
ZhiyuCircle,
ancazamfir,
romac and
sergio-mena
as code owners
September 24, 2026 21:40
Contributor
|
Hi @ZanCorDX, Thank you for your interest in contributing to Arc Node. This PR has been automatically closed because it does not reference a GitHub issue. All PRs must reference an existing issue using the format To contribute properly:
Please see our CONTRIBUTING.md for more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
App::start()opens the redb store before connecting to the execution engine.If the CL is terminated while it waits for the EL (up to 30 s of retries), no
SIGTERM handler is installed yet, so the process dies with the store open and
without the quick-repair commit that redb performs on
Drop. The next start thenruns a full repair: 1h04 on a 103 GB testnet store.
This moves
open_storeto just beforeState::builder, its first use, so thestore is not open during the EL wait. No behavior change on the success path.
Reproduce (v0.8.0, EL stopped):
systemctl start arc-malachite; wait forDatabase openedand theFailed to connect to Ethereum noderetries.systemctl stop arc-malachiteduring the retries.systemctl start arc-malachite:Database repair in progress: 0.00%instead ofDatabase opened.With this patch, step 1 logs no
Opening databasebefore the EL check, andstep 3 opens the store immediately and completes the handshake.