Repository navigation
build(deps): security sweep of every dependency, tool pin and action - #2253
Conversation
pnpm 11 stops reading settings from package.json#pnpm and non-auth keys from .npmrc, so the overrides, patch and build allowlist move to pnpm-workspace.yaml (root and docs). auto-install-peers is the default, so .npmrc goes. minimumReleaseAge holds back any release younger than 7 days. pnpm 11.28.7 itself is excluded because it carries the registry name-mismatch fix. esbuild's postinstall is now denied. It only replaces the JS launcher with the native binary, and the JS API finds the platform package without it, so no dependency runs an install script. pnpm 11 exits non-zero when a --no-bail run fails, so the AGENTS.md warning about pnpm 10 goes. pnpm 11 needs Node 22.13.
obsidian-e2e 0.14.0 drops its vite-plus dependency. vite-plus 0.1.24 was the only path to GHSA-587h-7wmj-h5pm, GHSA-698v-4r3x-3vcv, GHSA-r825-w8mm-5pxw and two older Vite advisories. oxlint lists vite-plus only as an optional peer, so nothing installs it now. The lockfile is re-resolved from scratch so every transitive dependency moves to its newest release past the 7-day cooldown. That also makes the brace-expansion, postcss and tinypool overrides unnecessary. tinypool and the old brace-expansion only came in through vite-plus, and postcss resolves to 8.5.30. pnpm audit reports no known vulnerabilities.
4.7.7 ships sveltejs/language-tools#3133, which the patch backported: svelte-check exits non-zero when the TypeScript process fails. Checked against 4.7.7: a type error in a .svelte or .ts file and a missing native compiler each fail `pnpm run check`. Dependabot no longer needs to skip svelte-check.
QuickAdd used one zustand/vanilla store with getState, a shallow-merging setState and subscribe. The local store keeps those semantics in ~30 lines, removing a production dependency from the bundle. The replace flag becomes its own replaceState, which callers already used, so tests that passed `setState(state, true)` call replaceState.
Nothing imports tslib. It was only there for `importHelpers`, which affects tsc emit, and tsc runs with noEmit. esbuild produces the bundle and inlines its own helpers.
The suite used five jest-dom matchers, 34 times in 9 files. Each maps to a DOM property: getAttribute, textContent, disabled, value and isConnected. Asserting those directly removes jest-dom and the 8 packages only it pulled in (@adobe/css-tools, css.escape, redent, ...).
Nothing in the docs site imports zod. Astro and @astrojs/sitemap bring their own. A fresh lockfile moves every transitive dependency to its newest release past the 7-day cooldown. expressive-code still pins postcss-nested 6, so the override that lifts postcss-selector-parser past GHSA-rj75-hqrm-r3gf stays, moving from postcss-nested 7.0.2 to 9.0.0. The built site is byte-identical with either version. Node 22 is in maintenance. Cloudflare Pages and the CI docs job read docs/.node-version, which now selects the active LTS, Node 24.
Node 24.22.1 is the October 2026 security release. Obsidian 1.14.4 is the newest installer past the 7-day cooldown. Templater 2.26.0 is its latest release. Each hash was checked against the publisher: the Node.js SHASUMS256 file, and the GitHub release asset digests for Obsidian and Templater.
Matches pnpm's minimumReleaseAge, so Dependabot stops proposing versions the install would reject. Security updates are not affected by the cooldown.
Deploying quickadd with
|
| Latest commit: |
994eff3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://aed983e7.quickadd.pages.dev |
| Branch Preview URL: | https://chore-deps-upgrade-2026-10.quickadd.pages.dev |
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Replace the settings store package.json, src/settingsStore.ts, src/settingsStore.test.ts, src/quickAddSettingsTab.ts, src/gui/svelte/persist.svelte.ts, src/gui/choiceList/* |
The settings store now manages state and listeners locally. Its API supports partial updates, full-state replacement, and subscriptions. Tests cover these operations, and call sites use the replacement API where they restore full state. |
Tooling and Test Updates
| Layer / File(s) | Summary |
|---|---|
Update runtimes and package policies .agents/*, .github/dependabot.yml, AGENTS.md, docs/.node-version, docs/package.json, docs/pnpm-workspace.yaml, package.json, patches/*, pnpm-workspace.yaml, tooling/README.md, tsconfig.json, .npmrc |
Runtime and package-manager pins changed across the project and docs. Workspace release-age and build-script settings, Dependabot cooldowns, and svelte-check guidance were updated. |
Remove matcher dependencies package.json, tests/vitest-setup.ts, src/gui/ChoiceBuilder/*, src/gui/MultiChoiceBuilder.test.ts, src/gui/SearchableMultiSelect/*, src/gui/choiceList/*, src/gui/suggesters/* |
The test setup no longer imports jest-dom. Tests now check DOM properties, text, attributes, and connection state directly. |
Priority:
Estimated code review effort: 3 (Moderate) | ~20 minutes
Change: Other
Possibly related issues
- QuickAdd issue 2213 concerns settings-popout writes that arrive late or fail under load. This pull request changes the settings write path but does not state that it addresses that issue.
Merge Risk: 
Minimal · up to 994ef
-
No identified issue needs to be fixed before merging; normal checks still apply.
Pre-merge checks: 
4 · 
1
-
Failed checks: 1 warning Passed checks: 4 passedFull details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 17 files. (10 skipped: 10 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
-
Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit checks the store’s new state,
Then listens as updates circulate.
A pin shifts, a test asserts,
The workspace gets refreshed alerts.
Soft paws hop through each changed file,
Then rest beside the green test pile.
Comment @coderabbitai help to get the list of available commands.
Security sweep of every dependency, pinned tool and CI action. It closes the three open Dependabot alerts on
vite-plus. Plugin behavior does not change.Policy
"Latest safe" means the newest stable release that is at least 7 days old and has no known advisory. pnpm now enforces that (
minimumReleaseAge: 10080), and Dependabot gets a matching 7-day cooldown. Two versions are excluded, each with its reason inpnpm-workspace.yaml:pnpm@11.28.7carries the registry name-mismatch security fix.obsidian-e2e@0.14.0is ours, and it is the release that drops vite-plus.Remove each exclusion once its version is 7 days old (2026-10-28 and 2026-10-30).
No dependency runs an install script now. esbuild's postinstall is denied. It only swaps the JS launcher for the native binary, and the JS API finds the platform package without it.
Dependencies
packageManager, root + docs)package.json#pnpm/.npmrctopnpm-workspace.yaml,onlyBuiltDependenciesbecomesallowBuilds, and.npmrcis removed.patches/svelte-check@4.7.6.patchis deleted because 4.7.7 ships sveltejs/language-tools#3133. The Dependabot ignore goes too.src/settingsStore.ts(about 30 lines).importHelpers.brace-expansionpostcsstinypoolpostcss-nesteddocs/.node-version).agents/setup).agents/setup).agents/run-e2e)prepareFuzzySearchwould change ranking and cannot run in unit tests.test:coverageis documented in ARCHITECTURE.md.packageManager.pnpm auditreports no known vulnerabilities in either lockfile. Every package in both lockfiles was checked against the registry for publish age, install scripts and deprecation. The only install scripts are esbuild's (denied) and fsevents' (macOS-only optional, not built).Code migrations
settingsStorekeeps zustand/vanilla's semantics: a shallow merge, anObject.isskip, insertion-order listeners called with(state, previous), and the same reentrancy. Thereplaceflag becomes thereplaceStatecallers already used.src/settingsStore.test.tscovers merge, replace, notify, unsubscribe and the no-op case.toHaveAttribute,toHaveTextContent,toBeDisabled,toHaveValueandtoBeInTheDocumentbecomegetAttribute,textContent,disabled,valueandisConnected. A mutated expectation fails as it should.--no-bailrun fails (checked against pnpm 10, which exits 0), so the AGENTS.md warning is gone.Verification
pnpm run build,pnpm run build-with-lint,pnpm run test(6962 passed, 28 skipped),pnpm run test:coverage, and the docs build plus link check all pass at HEAD. Each commit passes install, build-with-lint, test and (for docs commits) the docs build on its own.pnpm run checkstill fails closed on 4.7.7 without the patch. A type error in a.sveltefile, a type error in a.tsfile, and a missing native compiler each exit 1.OBSIDIAN_E2E_TEMPLATER=1 .agents/run-e2e): 493/493 passed on the Obsidian 1.13.7 installer, and 493/493 passed on the 1.14.4 installer.Risks and follow-ups
lockfileVersion: '9.0', and pnpm 10 switches itself to the pinned 11.28.7. After merge, trigger a Dependabot check for/and/docsand confirm it opens a PR.minimumReleaseAgeExcludeentry before its PR can install.pnpm install --frozen-lockfilehere, which self-switches to 11.28.7. This was verified locally, but not in the release workflow itself.packageManagerand.node-version.No release or migration impact for users. The plugin bundle loses zustand and is otherwise unchanged.
Checklist
build(deps)releases a patch, which fits because the bundle drops zustand.Note
Medium Risk
Touches install policy (pnpm 11, no lifecycle scripts), CI/Dependabot behavior, and the settings store implementation used across the UI—low user-facing change but broad dev/CI blast radius if something mis-resolves.
Overview
Security-focused dependency and toolchain refresh that upgrades pnpm 10 → 11, bumps pinned Node/Obsidian/Templater for native e2e, and re-resolves root and docs lockfiles (notably removing vite-plus via obsidian-e2e@0.14 and dropping several overrides/patches).
Supply-chain policy moves into
pnpm-workspace.yaml: 7-dayminimumReleaseAge,allowBuilds(esbuild install denied), and matching Dependabot cooldown; rootpackage.json#pnpm/.npmrcgo away.Runtime/code changes are mostly internal:
zustandis replaced by a small in-reposettingsStore(same merge/subscribe semantics; tests usereplaceState);svelte-check4.7.7 replaces the deleted patch;@testing-library/jest-domis removed and Vitest DOM checks use plain assertions. Docs align on Node 24 andpostcss-nested9.0.0 override.Reviewed by Cursor Bugbot for commit 994eff3. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Sweep dependencies: replace Zustand with
settingsStore, drop jest-dom and tslibsrc/gui/**and new coverage added in settingsStore.test.ts@testing-library/jest-dom,tslib, andzustandas direct deps; test suites now usegetAttribute,isConnected, andtextContentchecks instead of jest-dom matchers. Drops theimportHelpersoption from tsconfig.jsonsettingsStore.ts— listeners now receive current and previous state, andsetStatewith a full replacement object bypasses shallow merge (usereplaceState);setStateno longer notifies when given the identical state objectMacroscope summarized 994eff3.
Summary by CodeRabbit
Chores
Tests
User Impact