Skip to content

build(deps): security sweep of every dependency, tool pin and action - #2253

Merged
chhoumann merged 9 commits into
masterfrom
chore/deps-upgrade-2026-10
Oct 24, 2026
Merged

chhoumann merged 9 commits into
masterfrom
chore/deps-upgrade-2026-10

Conversation

@chhoumann

@chhoumann chhoumann commented Oct 24, 2026 •

Copy link
Copy Markdown
Owner

Security sweep of every dependency, pinned tool and CI action. It closes the three open Dependabot alerts on vite-plus. Plugin behavior does not change.

Policy

"Latest safe" means the newest stable release that is at least 7 days old and has no known advisory. pnpm now enforces that (minimumReleaseAge: 10080), and Dependabot gets a matching 7-day cooldown. Two versions are excluded, each with its reason in pnpm-workspace.yaml:

  • pnpm@11.28.7 carries the registry name-mismatch security fix.
  • obsidian-e2e@0.14.0 is ours, and it is the release that drops vite-plus.

Remove each exclusion once its version is 7 days old (2026-10-28 and 2026-10-30).

No dependency runs an install script now. esbuild's postinstall is denied. It only swaps the JS launcher for the native binary, and the JS API finds the platform package without it.

Dependencies

Dependency Old New Outcome
pnpm (packageManager, root + docs) 10.32.1 11.28.7 Migrated. Config moves from package.json#pnpm / .npmrc to pnpm-workspace.yaml, onlyBuiltDependencies becomes allowBuilds, and .npmrc is removed.
obsidian-e2e ^0.13.0 ^0.14.0 Bumped. Drops vite-plus and fixes GHSA-587h-7wmj-h5pm, GHSA-698v-4r3x-3vcv, GHSA-r825-w8mm-5pxw, GHSA-rq7h-c2jc-7f22 and GHSA-9jrq-w75r-8gcw.
vite-plus (transitive) 0.1.24 - Removed from the tree. oxlint lists it only as an optional peer.
svelte-check 4.7.6 + patch 4.7.7 Bumped. patches/svelte-check@4.7.6.patch is deleted because 4.7.7 ships sveltejs/language-tools#3133. The Dependabot ignore goes too.
zustand ^5.0.15 - Vendored as src/settingsStore.ts (about 30 lines).
tslib ^2.8.1 - Removed, together with importHelpers.
@testing-library/jest-dom ^7.0.1 - Removed. 34 matcher calls become plain DOM assertions.
override brace-expansion 5.0.9 - Removed. The package is no longer in the graph.
override postcss 8.5.25 - Removed. It resolves to 8.5.30 without it.
override tinypool 2.1.2 - Removed. It only came in through vite-plus.
docs: zod 4.6.7 - Removed. Nothing imports it, and Astro brings its own copy.
docs: override postcss-nested 7.0.2 9.0.0 Bumped. Still needed for GHSA-rj75-hqrm-r3gf, since expressive-code asks for postcss-nested 6. The built site is byte-identical.
docs: Node (docs/.node-version) 22 24 Bumped. Node 22 is in maintenance and 24 is the active LTS.
e2e: Node (.agents/setup) 24.19.0 24.22.1 Bumped (October 2026 security release). The hash comes from SHASUMS256.
e2e: Obsidian installer (.agents/setup) 1.13.7 1.14.4 Bumped. The hash matches the release asset digest. 1.14.5 is under 7 days old.
e2e: Templater (.agents/run-e2e) 2.25.1 2.26.0 Bumped. The hashes match the release asset digests.
Transitive (root lockfile) 332 packages 247 packages The lockfile was re-resolved from scratch to the newest mature versions.
Transitive (docs lockfile) 423 packages 390 packages Re-resolved from scratch.
chrono-node ^2.10.3 ^2.10.3 Kept, already latest. Natural-language date parsing is too large to vendor.
fuse.js ^7.5.0 ^7.5.0 Kept, already latest. FileIndex relies on weighted keys, two thresholds and scores. Obsidian's prepareFuzzySearch would change ranking and cannot run in unit tests.
svelte-dnd-action 0.9.80 0.9.80 Kept, already latest. The surface is large: three dndzones and the #1692 fallback.
three-way-merge ^0.1.0 ^0.1.0 Kept. It is one function, but about 800 lines of diff3. It is frozen since 2017, has no dependencies and no scripts, so vendoring it buys nothing.
@sveltejs/vite-plugin-svelte ^7.3.1 ^7.3.1 Kept, already latest.
@testing-library/svelte ^5.4.2 ^5.4.2 Kept, already latest.
@types/node ^26.6.5 ^26.6.5 Kept, already latest.
@typescript/native (typescript 7) 7.0.2 7.0.2 Kept, already latest.
typescript (@typescript/typescript6) 6.0.2 6.0.2 Kept, already latest. svelte-check still loads the TS 6 API.
@vitest/coverage-v8 5.0.5 5.0.5 Kept, already latest. test:coverage is documented in ARCHITECTURE.md.
esbuild ^0.28.2 ^0.28.2 Kept, already latest. Its build script is now denied.
esbuild-svelte ^0.9.5 ^0.9.5 Kept, already latest. One call site, but it owns compile, CSS and watch-cache handling, which is not a small piece.
jsdom ^30.1.3 ^30.1.3 Kept, already latest.
moment 2.31.0 2.31.0 Kept, already latest. Tests import the real moment.
obsidian 1.14.4 1.14.4 Kept, already latest.
oxlint 1.88.0 1.88.0 Held. 1.89.0 is 5 days old.
oxlint-tsgolint 7.0.2004 7.0.2004 Held. 7.0.2005 is 2 days old.
svelte ^5.57.2 ^5.57.2 Kept, already latest.
svelte-policy ^0.1.0 ^0.1.0 Kept, already latest (ours).
vite ^8.3.4 ^8.3.4 Held. 8.3.5 is 3 days old and has no security fix. Kept as a direct dependency because vite-plugin-svelte peers on it.
vitest ^5.0.5 ^5.0.5 Kept, already latest.
yaml 2.9.1 2.9.1 Kept, already latest. Used by the test template harness.
docs: astro ^7.4.0 ^7.4.0 Held. 7.4.1 and 7.4.2 are under 7 days old and contain no security fix. 7.4.2's only security note is a Node floor, which Node 24.22.1 meets.
docs: @astrojs/starlight ^0.42.6 ^0.42.6 Held. 0.42.7 is 1 day old.
docs: @astrojs/markdown-satteri ^0.4.4 ^0.4.4 Held. 0.4.5 is 3 days old.
docs: sharp ^0.35.5 ^0.35.5 Kept, already latest.
docs: starlight-llms-txt ^0.12.0 ^0.12.0 Kept, already latest.
actions/checkout v7.0.1 v7.0.1 Kept, already latest. The SHA pin was checked against the tag.
actions/setup-node v7.1.0 v7.1.0 Kept, already latest. SHA checked.
pnpm/action-setup v6.1.0 v6.1.0 Kept, already latest. SHA checked. It reads pnpm 11 from packageManager.
actions/dependency-review-action v5.0.0 v5.0.0 Kept, already latest. SHA checked.
amannn/action-semantic-pull-request v6.1.1 v6.1.1 Kept, already latest. SHA checked.
step-security/harden-runner v2.22.1 v2.22.1 Held. v2.22.2 is 5 days old and only fixes macOS and enterprise issues. SHA checked.
github/codeql-action v4.39.0 v4.39.0 Held. v4.39.1 is 3 days old and only bumps the bundle. SHA checked.
chhoumann/obsidian-plugin-workflows v4 (ebcf84b) v4 (ebcf84b) Kept. No newer release is published. SHA checked.

pnpm audit reports no known vulnerabilities in either lockfile. Every package in both lockfiles was checked against the registry for publish age, install scripts and deprecation. The only install scripts are esbuild's (denied) and fsevents' (macOS-only optional, not built).

Code migrations

  • zustand. settingsStore keeps zustand/vanilla's semantics: a shallow merge, an Object.is skip, insertion-order listeners called with (state, previous), and the same reentrancy. The replace flag becomes the replaceState callers already used. src/settingsStore.test.ts covers merge, replace, notify, unsubscribe and the no-op case.
  • jest-dom. toHaveAttribute, toHaveTextContent, toBeDisabled, toHaveValue and toBeInTheDocument become getAttribute, textContent, disabled, value and isConnected. A mutated expectation fails as it should.
  • pnpm 11. It exits non-zero when a --no-bail run fails (checked against pnpm 10, which exits 0), so the AGENTS.md warning is gone.

Verification

  • pnpm run build, pnpm run build-with-lint, pnpm run test (6962 passed, 28 skipped), pnpm run test:coverage, and the docs build plus link check all pass at HEAD. Each commit passes install, build-with-lint, test and (for docs commits) the docs build on its own.
  • pnpm run check still fails closed on 4.7.7 without the patch. A type error in a .svelte file, a type error in a .ts file, and a missing native compiler each exit 1.
  • Native e2e with Templater 2.26.0 (OBSIDIAN_E2E_TEMPLATER=1 .agents/run-e2e): 493/493 passed on the Obsidian 1.13.7 installer, and 493/493 passed on the 1.14.4 installer.
  • Two independent reviews ran, Claude Fable 5.1 and GPT 6.0 Astra. Their stale-comment and documentation findings are folded into the commits.

Risks and follow-ups

  • Dependabot on pnpm 11 is unverified. GitHub documents pnpm support up to v10. The lockfile is still lockfileVersion: '9.0', and pnpm 10 switches itself to the pinned 11.28.7. After merge, trigger a Dependabot check for / and /docs and confirm it opens a PR.
  • Security updates still need a manual step. Dependabot security updates skip its cooldown, but pnpm's age gate does not. A security fix younger than 7 days needs a minimumReleaseAgeExclude entry before its PR can install.
  • Release workflow. The shared release workflow installs its toolkit's pnpm 10, then runs pnpm install --frozen-lockfile here, which self-switches to 11.28.7. This was verified locally, but not in the release workflow itself.
  • Cloudflare Pages. The docs now build with pnpm 11 and Node 24. The CI Docs job mirrors that, and Cloudflare supports any version through packageManager and .node-version.

No release or migration impact for users. The plugin bundle loses zustand and is otherwise unchanged.

Checklist


Note

Medium Risk
Touches install policy (pnpm 11, no lifecycle scripts), CI/Dependabot behavior, and the settings store implementation used across the UI—low user-facing change but broad dev/CI blast radius if something mis-resolves.

Overview
Security-focused dependency and toolchain refresh that upgrades pnpm 10 → 11, bumps pinned Node/Obsidian/Templater for native e2e, and re-resolves root and docs lockfiles (notably removing vite-plus via obsidian-e2e@0.14 and dropping several overrides/patches).

Supply-chain policy moves into pnpm-workspace.yaml: 7-day minimumReleaseAge, allowBuilds (esbuild install denied), and matching Dependabot cooldown; root package.json#pnpm / .npmrc go away.

Runtime/code changes are mostly internal: zustand is replaced by a small in-repo settingsStore (same merge/subscribe semantics; tests use replaceState); svelte-check 4.7.7 replaces the deleted patch; @testing-library/jest-dom is removed and Vitest DOM checks use plain assertions. Docs align on Node 24 and postcss-nested 9.0.0 override.

Reviewed by Cursor Bugbot for commit 994eff3. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Sweep dependencies: replace Zustand with settingsStore, drop jest-dom and tslib

  • Replaces the Zustand store in settingsStore.ts with a local state container: shallow partial updates, whole-state replacement, listener subscribe/unsubscribe, and no notification when the state is unchanged. Tests updated across src/gui/** and new coverage added in settingsStore.test.ts
  • Removes @testing-library/jest-dom, tslib, and zustand as direct deps; test suites now use getAttribute, isConnected, and textContent checks instead of jest-dom matchers. Drops the importHelpers option from tsconfig.json
  • Upgrades tooling: Node.js >=22.13.0 (24.22.1 in setup), pnpm 11.28.7, obsidian-e2e 0.14.0, svelte-check 4.7.7, Obsidian 1.14.4, Templater 2.26.0
  • Deletes the svelte-check 4.7.6 patch (upstream now needs 4.7.7+) and removes the svelte-check Dependabot ignore
  • Adds a seven-day minimum release age for pnpm installs and a seven-day Dependabot cooldown in dependabot.yml
  • Risk: store semantics changed in settingsStore.ts — listeners now receive current and previous state, and setState with a full replacement object bypasses shallow merge (use replaceState); setState no longer notifies when given the identical state object

Macroscope summarized 994eff3.

Summary by CodeRabbit

  • Chores

    • Updated the development and documentation toolchains and refreshed supporting package versions.
    • Adjusted dependency update timing and package installation settings.
  • Tests

    • Updated automated checks to remain compatible with the current testing tools.
  • User Impact

    • No changes to app features or behavior are included in this update.

pnpm 11 stops reading settings from package.json#pnpm and non-auth keys
from .npmrc, so the overrides, patch and build allowlist move to
pnpm-workspace.yaml (root and docs). auto-install-peers is the default,
so .npmrc goes.

minimumReleaseAge holds back any release younger than 7 days.
pnpm 11.28.7 itself is excluded because it carries the registry
name-mismatch fix.

esbuild's postinstall is now denied. It only replaces the JS launcher
with the native binary, and the JS API finds the platform package
without it, so no dependency runs an install script.

pnpm 11 exits non-zero when a --no-bail run fails, so the AGENTS.md
warning about pnpm 10 goes. pnpm 11 needs Node 22.13.
obsidian-e2e 0.14.0 drops its vite-plus dependency. vite-plus 0.1.24 was
the only path to GHSA-587h-7wmj-h5pm, GHSA-698v-4r3x-3vcv,
GHSA-r825-w8mm-5pxw and two older Vite advisories. oxlint lists vite-plus
only as an optional peer, so nothing installs it now.

The lockfile is re-resolved from scratch so every transitive dependency
moves to its newest release past the 7-day cooldown. That also makes the
brace-expansion, postcss and tinypool overrides unnecessary. tinypool and
the old brace-expansion only came in through vite-plus, and postcss
resolves to 8.5.30. pnpm audit reports no known vulnerabilities.
4.7.7 ships sveltejs/language-tools#3133, which the patch backported:
svelte-check exits non-zero when the TypeScript process fails. Checked
against 4.7.7: a type error in a .svelte or .ts file and a missing
native compiler each fail `pnpm run check`. Dependabot no longer needs to
skip svelte-check.
QuickAdd used one zustand/vanilla store with getState, a shallow-merging
setState and subscribe. The local store keeps those semantics in ~30
lines, removing a production dependency from the bundle.

The replace flag becomes its own replaceState, which callers already
used, so tests that passed `setState(state, true)` call replaceState.
Nothing imports tslib. It was only there for `importHelpers`, which
affects tsc emit, and tsc runs with noEmit. esbuild produces the bundle
and inlines its own helpers.
The suite used five jest-dom matchers, 34 times in 9 files. Each maps to
a DOM property: getAttribute, textContent, disabled, value and
isConnected. Asserting those directly removes jest-dom and the 8
packages only it pulled in (@adobe/css-tools, css.escape, redent, ...).
Nothing in the docs site imports zod. Astro and @astrojs/sitemap bring
their own. A fresh lockfile moves every transitive dependency to its
newest release past the 7-day cooldown.

expressive-code still pins postcss-nested 6, so the override that lifts
postcss-selector-parser past GHSA-rj75-hqrm-r3gf stays, moving from
postcss-nested 7.0.2 to 9.0.0. The built site is byte-identical with
either version.

Node 22 is in maintenance. Cloudflare Pages and the CI docs job read
docs/.node-version, which now selects the active LTS, Node 24.
Node 24.22.1 is the October 2026 security release. Obsidian 1.14.4 is
the newest installer past the 7-day cooldown. Templater 2.26.0 is its
latest release. Each hash was checked against the publisher: the
Node.js SHASUMS256 file, and the GitHub release asset digests for
Obsidian and Templater.
Matches pnpm's minimumReleaseAge, so Dependabot stops proposing versions
the install would reject. Security updates are not affected by the
cooldown.
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Deploying quickadd with  Cloudflare Pages  Cloudflare Pages

Latest commit: 994eff3
Status: ✅  Deploy successful!
Preview URL: https://aed983e7.quickadd.pages.dev
Branch Preview URL: https://chore-deps-upgrade-2026-10.quickadd.pages.dev

View logs

@coderabbitai

coderabbitai Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 6ff9baa3-4d98-4857-ac70-12e1543b2378
Commits

Reviewing files that changed from the base of the PR and between 59721f2 and 994eff3.

Files ignored due to path filters: 2
  • docs/pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
Files selected for processing: 30
  • .agents/run-e2e
  • .agents/setup
  • .github/dependabot.yml
  • .npmrc
  • AGENTS.md
  • docs/.node-version
  • docs/package.json
  • docs/pnpm-workspace.yaml
  • package.json
  • patches/svelte-check@4.7.6.patch
  • pnpm-workspace.yaml
  • src/gui/ChoiceBuilder/CaptureChoiceForm.test.ts
  • src/gui/ChoiceBuilder/TemplateChoiceForm.test.ts
  • src/gui/MultiChoiceBuilder.test.ts
  • src/gui/SearchableMultiSelect/searchableMultiSelect.test.ts
  • src/gui/choiceList/ChoiceView.addRace.test.ts
  • src/gui/choiceList/ChoiceView.aiEntry.test.ts
  • src/gui/choiceList/ChoiceView.externalEdit.test.ts
  • src/gui/choiceList/ChoiceView.malformed.test.ts
  • src/gui/choiceList/ChoiceView.rowActions.test.ts
  • src/gui/choiceList/ChoiceView.test.ts
  • src/gui/choiceList/seedChoiceTree.ts
  • src/gui/suggesters/choiceSuggester.test.ts
  • src/gui/svelte/persist.svelte.ts
  • src/quickAddSettingsTab.ts
  • src/settingsStore.test.ts
  • src/settingsStore.ts
  • tests/vitest-setup.ts
  • tooling/README.md
  • tsconfig.json
Files with no reviewable changes: 3

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

Walkthrough

The pull request replaces the Zustand-backed settings store with a local implementation and updates its tests and call sites. It also updates runtime and package-manager pins, workspace and Dependabot policies, and test assertions.

Changes: Local Settings Store

Layer / File(s) Summary
Replace the settings store
package.json, src/settingsStore.ts, src/settingsStore.test.ts, src/quickAddSettingsTab.ts, src/gui/svelte/persist.svelte.ts, src/gui/choiceList/*
The settings store now manages state and listeners locally. Its API supports partial updates, full-state replacement, and subscriptions. Tests cover these operations, and call sites use the replacement API where they restore full state.

Tooling and Test Updates

Layer / File(s) Summary
Update runtimes and package policies
.agents/*, .github/dependabot.yml, AGENTS.md, docs/.node-version, docs/package.json, docs/pnpm-workspace.yaml, package.json, patches/*, pnpm-workspace.yaml, tooling/README.md, tsconfig.json, .npmrc
Runtime and package-manager pins changed across the project and docs. Workspace release-age and build-script settings, Dependabot cooldowns, and svelte-check guidance were updated.
Remove matcher dependencies
package.json, tests/vitest-setup.ts, src/gui/ChoiceBuilder/*, src/gui/MultiChoiceBuilder.test.ts, src/gui/SearchableMultiSelect/*, src/gui/choiceList/*, src/gui/suggesters/*
The test setup no longer imports jest-dom. Tests now check DOM properties, text, attributes, and connection state directly.

Priority: Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Other

Possibly related issues

  • QuickAdd issue 2213 concerns settings-popout writes that arrive late or fail under load. This pull request changes the settings write path but does not state that it addresses that issue.
Merge Risk: Minimal · up to 994ef

No identified issue needs to be fixed before merging; normal checks still apply.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 17 files. (10 skipped: … Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly summarizes the main changes: dependency updates, tool pin changes, and CI action security policies.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 17 files. (10 skipped: 10 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches: 💡 1
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the store’s new state,
Then listens as updates circulate.
A pin shifts, a test asserts,
The workspace gets refreshed alerts.
Soft paws hop through each changed file,
Then rest beside the green test pile.

Comment @coderabbitai help to get the list of available commands.

@chhoumann
chhoumann marked this pull request as ready for review October 24, 2026 08:13
@chhoumann
chhoumann merged commit c45eaf2 into master Oct 24, 2026
18 of 19 checks passed
@chhoumann
chhoumann deleted the chore/deps-upgrade-2026-10 branch October 24, 2026 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant