Repository navigation
ci: pin the shared release workflows to v4.1.0 - #2254
Conversation
A caller pnpm-workspace.yaml made the v4 (ebcf84b) toolkit install resolve to QuickAdd's workspace, so it installed QuickAdd's packages instead of the toolkit's and still exited 0. v4.1.0 makes the toolkit its own workspace root and moves it to pnpm 10.34.7. No inputs, secrets or permissions change.
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Update reusable workflow pins .github/workflows/release-prepare.yml, .github/workflows/release-trigger.yml, .github/workflows/release.yml |
All three workflows now use commit 149e37801b35c120660a1fd5e78a5471fda55726 instead of the v4 commit. Other workflow settings remain unchanged. |
Priority:
Estimated code review effort: 1 (Trivial) | ~5 minutes
Change: Bug fix
Possibly related PRs
- chhoumann/quickadd#2253: This PR changed the workspace setup, and the supplied summary links that change to the release workflow behavior updated here.
Merge Risk: 
Minimal · up to e5530
-
The workflow pin updates preserve the reported caller configuration and introduce no actionable merge risk.
Pre-merge checks: 
5
-
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.)
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit checks the pins in place
Three workflows turn to v4.1.0
No inputs shift, no secrets roam
The release path keeps its form
Then off I hop, with carrots home
Comment @coderabbitai help to get the list of available commands.
Summary
Since #2253 added
pnpm-workspace.yaml, the shared release workflows pinned atebcf84b(v4) runpnpm --dir .release-toolkit installinside QuickAdd's workspace. That install pulls QuickAdd's packages instead of the toolkit's and still exits 0, which breaks the next release. chhoumann/obsidian-plugin-workflowsv4.1.0(149e378) fixes it: the toolkit is its own workspace root, and it runs on pnpm 10.34.7.Changes
release-prepare.yml,release-trigger.ymlandrelease.ymlpin149e37801b35c120660a1fd5e78a5471fda55726 # v4.1.0. Thev4.1.0tag object dereferences to that SHA.ebcf84b.Testing / validation
After merge, a dry run of Prepare release (
dry-run: true) on master confirms that the toolkit install uses pnpm 10.34.7 and installs the toolkit's own dependencies.Checklist
ci:, no release).Note
Low Risk
CI-only pin bump with the same caller contract; lowers risk of broken releases versus staying on v4.
Overview
Bumps the reusable
chhoumann/obsidian-plugin-workflowspins from commitebcf84b(v4) to149e378(v4.1.0) inrelease-prepare.yml,release-trigger.yml, andrelease.yml.That upgrade fixes release prep after the repo’s
pnpm-workspace.yamlcaused v4’s toolkit install to resolve QuickAdd’s workspace packages instead of the release toolkit’s—silently succeeding but breaking later release steps. v4.1.0 treats the toolkit as its own workspace root (pnpm 10.34.7). Workflow inputs, secrets, and permissions are unchanged.Reviewed by Cursor Bugbot for commit e553072. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Pin shared release workflows to v4.1.0
Updates the
preparejob in release-prepare.yml to use the shared release-preparation workflow at commit149e378, tagged v4.1.0. Job conditions, permissions, inputs, and secrets are unchanged.Macroscope summarized e553072.
Summary by CodeRabbit