Skip to content

Oxfmt #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sjvans wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Oxfmt #438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c00eb46
ignore .claude/
sjvans Jun 22, 2026
9a36e8f
oxfmt
sjvans Jun 22, 2026
9468fc6
lint-staged
sjvans Jun 22, 2026
fce92fd
husky
sjvans Jun 22, 2026
a162104
"prepare": "npx lint-staged"
sjvans Jun 22, 2026
7eea0c3
rm husky
sjvans Jun 22, 2026
a994959
reduce diff
sjvans Jun 22, 2026
2006a72
formatting
sjvans Jun 22, 2026
de0e960
re-add husky
sjvans Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,3 +136,5 @@ dist
test/msg-box
test/bookshop/gen
test/bookshop/.cdsrc.json

.claude/
1 change: 1 addition & 0 deletions .husky/pre-commit
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
npx lint-staged
21 changes: 21 additions & 0 deletions .oxfmtrc.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"$schema": "./node_modules/oxfmt/configuration_schema.json",
"arrowParens": "avoid",
"bracketSpacing": true,
"embeddedLanguageFormatting": "auto",
"htmlWhitespaceSensitivity": "css",
"insertPragma": false,
"jsxSingleQuote": false,
"printWidth": 120,
"proseWrap": "preserve",
"quoteProps": "as-needed",
"requirePragma": false,
"semi": false,
"singleQuote": true,
"tabWidth": 2,
"trailingComma": "none",
"useTabs": false,
"vueIndentScriptAndStyle": false,
"sortPackageJson": false,
"ignorePatterns": ["*.md"]
}
4 changes: 3 additions & 1 deletion jest.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@ if (process.env.CI && process.env.HANA_DRIVER) {
config.testMatch = ['**/tracing-attributes.test.js', '**/passport.test.js']

if (process.env.HANA_PROM)
process.env.cds_requires_telemetry_tracing = JSON.stringify({ _hana_prom: process.env.HANA_PROM === 'true' })
process.env.cds_requires_telemetry_tracing = JSON.stringify({
_hana_prom: process.env.HANA_PROM === 'true'
})
Comment on lines +11 to +13

@hyperspace-insights hyperspace-insights Bot Jun 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting: The object key _hana_prom is not indented - it's at column 0 instead of being indented inside the object literal, which is inconsistent and hard to read.

Suggested change
process.env.cds_requires_telemetry_tracing = JSON.stringify({
_hana_prom: process.env.HANA_PROM === 'true'
})
process.env.cds_requires_telemetry_tracing = JSON.stringify({
_hana_prom: process.env.HANA_PROM === 'true',
})

Double-check suggestion before committing. Edit this comment for amendments.

Please provide feedback on the review comment by checking the appropriate box:

  • 🌟 Awesome comment, a human might have missed that.
  • ✅ Helpful comment
  • 🤷 Neutral
  • ❌ This comment is not helpful

}

module.exports = config
4 changes: 3 additions & 1 deletion lib/exporter/ConsoleMetricExporter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,9 @@ class ConsoleMetricExporter extends StandardConsoleMetricExporter {
// export other metrics
for (const tenant of Object.keys(other)) {
for (const [k, v] of Object.entries(other[tenant])) {
LOG.info(`${k}${tenant !== 'undefined' ? ` of tenant "${tenant}"` : ''}: ${inspect(v.length === 1 ? v[0] : v)}`)
LOG.info(
`${k}${tenant !== 'undefined' ? ` of tenant "${tenant}"` : ''}: ${inspect(v.length === 1 ? v[0] : v)}`
)
}
}
}
Expand Down
10 changes: 9 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,14 @@
"lib"
],
"scripts": {
"fmt": "npx oxfmt",
"lint": "npx eslint .",
"prepare": "husky",
"test": "npx jest --silent"
},
"lint-staged": {
"*": "oxfmt --no-error-on-unmatched-pattern"
},
"dependencies": {
"@opentelemetry/api": "^1.9",
"@opentelemetry/core": "^1.30",
Expand Down Expand Up @@ -48,7 +53,10 @@
"chai-as-promised": "^7.1.1",
"chai-subset": "^1.6.0",
"eslint": "^10",
"jest": "^29.7.0"
"husky": "^9.1.7",
"jest": "^29.7.0",
"lint-staged": "^17.0.8",
"oxfmt": "^0.56.0"
},
"cds": {
"requires": {
Expand Down