Conversation
SummaryThe following content is AI-generated and provides a summary of the pull request: Integrate
|
There was a problem hiding this comment.
The PR is exploratory ("playing around with oxfmt") but has a concrete formatting regression in jest.config.js where the newly reformatted object literal has its key at column 0, suggesting the formatter output was applied incorrectly or the tool has a bug at that indentation level. The missing newline at EOF in the formatter's own config file is also worth addressing.
PR Bot Information
Version: 1.26.5
- Event Trigger:
pull_request.opened - Correlation ID:
9c9108ba-9281-4f2d-86e1-bfbfcbeeda47 - File Content Strategy: Full file content
- LLM:
anthropic--claude-4.6-sonnet
| process.env.cds_requires_telemetry_tracing = JSON.stringify({ | ||
| _hana_prom: process.env.HANA_PROM === 'true' | ||
| }) |
There was a problem hiding this comment.
Formatting: The object key _hana_prom is not indented - it's at column 0 instead of being indented inside the object literal, which is inconsistent and hard to read.
| process.env.cds_requires_telemetry_tracing = JSON.stringify({ | |
| _hana_prom: process.env.HANA_PROM === 'true' | |
| }) | |
| process.env.cds_requires_telemetry_tracing = JSON.stringify({ | |
| _hana_prom: process.env.HANA_PROM === 'true', | |
| }) | |
Double-check suggestion before committing. Edit this comment for amendments.
Please provide feedback on the review comment by checking the appropriate box:
- 🌟 Awesome comment, a human might have missed that.
- ✅ Helpful comment
- 🤷 Neutral
- ❌ This comment is not helpful
| "oxfmt": "^0.56.0" | ||
| }, | ||
| "peerDependencies": { | ||
| "@sap/cds": "^8 || ^9" |
There was a problem hiding this comment.
Bug: peerDependencies was moved to after devDependencies, which is unconventional, but more critically it was temporarily removed and re-added — verify the final file still contains @sap/cds as a peer dependency (it does at lines 57-59), but this reordering should be intentional.
Please provide feedback on the review comment by checking the appropriate box:
- 🌟 Awesome comment, a human might have missed that.
- ✅ Helpful comment
- 🤷 Neutral
- ❌ This comment is not helpful
| "ignorePatterns": [ | ||
| "*.md" | ||
| ] | ||
| } No newline at end of file |
There was a problem hiding this comment.
Best Practice: File is missing a trailing newline (\ No newline at end of file) - most linters and editors expect a newline at end of file, and it's inconsistent with the formatter's own intent.
Please provide feedback on the review comment by checking the appropriate box:
- 🌟 Awesome comment, a human might have missed that.
- ✅ Helpful comment
- 🤷 Neutral
- ❌ This comment is not helpful
playing around with https://oxc.rs/docs/guide/usage/formatter.html