Skip to content

fix(cli): the manual kind hint frees the control-plane zone #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmscomp merged 1 commit into from
Nov 5, 2026
Merged

fix(cli): the manual kind hint frees the control-plane zone #613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion cli/cmd/cluster_gate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,10 @@ func offerKind(d cluster.Decision) (string, error) {
how := "Re-run kates deploy in a terminal to be asked."
if configExistsFn(cluster.DefaultKindConfig) {
how = fmt.Sprintf("Re-run in a terminal to be prompted, or create it directly:\n"+
" kind create cluster --config %s --name %s", cluster.DefaultKindConfig, cluster.DefaultKindClusterName)
" kind create cluster --config %s --name %s\n"+
// The first zone is the control-plane node, and Kafka pods pin to each zone.
" kubectl taint nodes %s node-role.kubernetes.io/control-plane:NoSchedule-",
cluster.DefaultKindConfig, cluster.DefaultKindClusterName, cluster.KindZones[0])
}
return "", fmt.Errorf("no reachable Kubernetes cluster.\n"+
" Docker and kind are available — a local %d-zone cluster can be created.\n %s",
Expand Down
3 changes: 3 additions & 0 deletions cli/cmd/cluster_gate_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,6 +514,9 @@ func TestResolveCluster_OfferKindNonTTYFailsWithoutPrompting(t *testing.T) {
if !strings.Contains(err.Error(), "kind create cluster") {
t.Errorf("error should give the manual command, got: %v", err)
}
if !strings.Contains(err.Error(), "kubectl taint nodes alpha node-role.kubernetes.io/control-plane:NoSchedule-") {
t.Errorf("error should free the control-plane zone, or Kafka stays Pending, got: %v", err)
}
}

// IsInteractive is the single guard everything else relies on.
Expand Down
Loading