Repository navigation
fix(cli): the manual kind hint frees the control-plane zone - #613
Merged
Merged
Conversation
Without a terminal, kates deploy prints the kind create cluster command to run by hand. A cluster made that way keeps the control-plane taint, kates deploy does not remove it from an existing cluster, and the alpha Kafka pods wait Pending for 15 minutes. The hint now gives the untaint command that CreateKind runs itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Without a terminal,
kates deploytells you to runkind create cluster --config config/cluster.yaml --name pandayourself. A cluster made that way keeps the control-plane taint, andalphais one of the three zones the Kafka pools pin to. A deploy onto an existing cluster does not remove the taint, so thealphapods wait Pending until the 15-minute timeout. Hit on a scratch cluster on 2026-11-05.What
The hint gains the
kubectl taintline thatCreateKindandscripts/start-cluster.shalready run.TestResolveCluster_OfferKindNonTTYFailsWithoutPromptingpins it.Deliberately not done
silent_wait.gostill does not stop early on a taint plus an affinity. That is a change to a wait rule for a rare case; this closes the route that leads there.KindZones[0]isalphain both copies of the kind config.Tests
go test ./cmd ./pkg/cluster,go vet ./cmd, gofmt.