[indent]

Production push logs show failed to decode GroupMe push message: json: cannot unmarshal string into Message.attachments.0.charmap.0.0 of type int for two accounts in one group, at the moment a still sticker was sent from the GroupMe iOS app. No Handling remote event followed for that message, and the reaction refresh on later restarts keeps logging Target message for reaction not found for its ID: it was dropped and catch-up never recovered it, because forward backfill skips IDs older than the newest bridged message.

Cause: still stickers are emoji attachments, and that client sends the charmap pairs as strings. groupme-lib typed Attachment.Charmap as [][]int, so the whole push message failed to decode.

Change: bump groupme-lib to beeper/groupme-lib#5, which decodes charmap entries from numbers or numeric strings. groupMeEmojiReplacer needs no change because the new type is still [][]int underneath. Repoint to the merge commit once #5 lands.

Tag @indent to continue the conversation here.

[indent]

Issues

All clear! No issues remaining. 🎉

1 issue already resolved

• The new groupme-lib charmap decoder fails the whole message on a null pair element, which the old [][]int type accepted as 0. Treat an empty json.Number as 0 in groupme-lib#5. (fixed by commit 5d4bfbe)
  _{Found by Indent Review Agent}

CI Checks

All CI checks passed on 5d4bfbe.

Review agents

Select any unchecked box below to run or rerun that agent.

Passed (1)

• Indent Review Agent · No issues found in the groupme-lib bump

Full results

Indent Review Agent

• Summary: No issues found in the groupme-lib bump
• Last ran on commit: 5d4bfbe2
• Latest result

  {
    "summary": "No issues found in the groupme-lib bump",
    "findings": []
  }