Repository navigation
deps: point groupme-lib at the charmap fix merge commit - #45
Merged
Merged
Conversation
Contributor
Author
|
No issues found.
All CI checks passed on
Select any unchecked box below to run or rerun that agent. Full resultsIndent Review Agent
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#44 pinned groupme-lib to the branch commit of beeper/groupme-lib#5 (62749e2). #5 has now merged as b70209d, so this points go.mod at that commit on the lib's
maininstead of the feature branch. The tree is identical (git diff 62749e2 b70209dis empty), so behavior doesn't change. It only stops the module depending on a branch commit that may be garbage-collected after the branch is deleted.go build ./...,go vet ./pkg/connector/andgo test ./pkg/...pass.Before / after
No runtime difference to test:
62749e2andb70209dpoint at the same git tree (356fc4f), so the bridge builds from identical groupme-lib source before and after.b70209dis the current tip of groupme-libmain. CI build, lint and test pass on this branch.Tag
@indentto continue the conversation here.