Skip to content

deps: point groupme-lib at the charmap fix merge commit - #45

Merged
iFixRobots merged 1 commit into
mainfrom
indent/groupme-repoint-charmap-lib
Nov 1, 2026
Merged

iFixRobots merged 1 commit into
mainfrom
indent/groupme-repoint-charmap-lib

Conversation

@indent

@indent indent Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

#44 pinned groupme-lib to the branch commit of beeper/groupme-lib#5 (62749e2). #5 has now merged as b70209d, so this points go.mod at that commit on the lib's main instead of the feature branch. The tree is identical (git diff 62749e2 b70209d is empty), so behavior doesn't change. It only stops the module depending on a branch commit that may be garbage-collected after the branch is deleted.

go build ./..., go vet ./pkg/connector/ and go test ./pkg/... pass.

Before / after

No runtime difference to test: 62749e2 and b70209d point at the same git tree (356fc4f), so the bridge builds from identical groupme-lib source before and after. b70209d is the current tip of groupme-lib main. CI build, lint and test pass on this branch.

View in Indent
Tag @indent to continue the conversation here.

@indent

indent Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor Author

Issues

No issues found.

CI Checks

All CI checks passed on 6e1d855.

Review agents

Select any unchecked box below to run or rerun that agent.

Passed (1)
  • Indent Review Agent · No issues; groupme-lib bump verified.
Full results

Indent Review Agent

  • Summary: No issues; groupme-lib bump verified.
  • Last ran on commit: 6e1d855a
  • Latest result
    {
      "summary": "No issues; groupme-lib bump verified.",
      "findings": []
    }

@indent indent Bot added the to be tested label Oct 31, 2026
@iFixRobots iFixRobots added can't be tested No way to run this change on a build; reviewed by source/CI only and removed to be tested labels Nov 1, 2026
@iFixRobots
iFixRobots merged commit 233acab into main Nov 1, 2026
5 checks passed
@iFixRobots
iFixRobots deleted the indent/groupme-repoint-charmap-lib branch November 1, 2026 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

can't be tested No way to run this change on a build; reviewed by source/CI only

Development

Successfully merging this pull request may close these issues.

2 participants