Repository navigation
Bridge GroupMe voice notes - #31
Merged
Merged
Conversation
Contributor
|
All clear! No issues remaining. 🎉 2 issues already resolved
All CI checks passed on
Select any unchecked box below to run or rerun that agent. Full resultsIndent Review Agent
|
# Conflicts: # pkg/connector/mediainfo.go
# Conflicts: # pkg/connector/capabilities.go # pkg/connector/mediainfo.go
# Conflicts: # go.mod # go.sum # pkg/connector/capabilities.go # pkg/connector/handlematrix.go
GroupMe's live DM events carry an audio attachment's peaks as a bare "0.0,0.125,..." string rather than the bracketed form groups use, so DM voice notes arrived without a waveform. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Tested live on a self-hosted bridge (main vs this branch), confirmed working after one fix:
Live DM events send the peaks as a bare |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GroupMe voice notes arrive in Beeper as the fallback text "⚠️ You received a voice note that may not be supported." There's also no mic button in GroupMe chats. The connector ignores
audioattachments, and the capabilities don't include voice:Incoming voice notes now become Matrix voice messages, with their duration and waveform, through both direct and downloaded media. The fallback text is hidden the same way GroupMe's web client hides it. Outgoing voice messages use the existing upload session, which already handles video, and are sent as an
audioattachment with duration, peaks and the transcript URL GroupMe returns. Voice capabilities only listaudio/mp4, so Beeper clients convert their recordings to.m4abefore sending, and the bridge doesn't need ffmpeg.This bumps groupme-lib to include beeper/groupme-lib#2, which adds the attachment fields.
Changelog: Added GroupMe voice notes.
Before / after
I haven't run this on a device yet; it needs a staging bridge build.
Tag
@indentto continue the conversation here.