Repository navigation
Only send voice messages as GroupMe voice notes - #33
Merged
Merged
Conversation
Contributor
|
No issues found.
All CI checks passed on
Select any unchecked box below to run or rerun that agent. Full resultsIndent Review Agent
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #31, every
m.audioevent goes out as a GroupMe voice note, not just voice messages. A plain audio file, like an .mp3 with a caption, arrives in GroupMe as a voice note and silently loses its caption:The room capabilities only advertise voice messages (
org.matrix.msc3245.voice,audio/mp4). GroupMe has nothing for plain audio files: its web client uploads them as group files.Audio without the voice flag now fails as unsupported again, which is what happened before #31. Voice messages are unchanged.
Changelog: Internal, no change for voice messages.
Before / after
I haven't run this on a device yet; it needs a staging bridge build.
Tag
@indentto continue the conversation here.