Support renamed gen_reference_docs target in Mintlify docs check - #2910
Open
kapunahelewong wants to merge 1 commit into
Open
kapunahelewong wants to merge 1 commit into
kapunahelewong wants to merge 1 commit into
Conversation
bazelbuild/bazel#31268 renames gen_mdx_reference_docs to gen_reference_docs, and the draft bazelbuild/bazel#31269 renames its output from mdx-reference-docs.zip to reference-docs.zip. Build whichever target the checked-out Bazel defines and ask Bazel for the output name, so the check works before and after both renames.
kapunahelewong
requested review from
fweikert and
ted-xie
and removed request for
a team
October 1, 2026 21:59
This was referenced Oct 1, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to bazelbuild/bazel#31211.
mintlify/check_docs.shhardcodes//src/main/java/com/google/devtools/build/lib:gen_mdx_reference_docsandmdx-reference-docs.zip. bazelbuild/bazel#31268 renames the target togen_reference_docs, so after it merges, the docs check on Bazel PRs would fail because it can't find the target.This PR:
gen_reference_docsif the checked-out Bazel defines it, and otherwise falls back togen_mdx_reference_docs, so older commits and release branches still work.bazel cquery --output=filesinstead of hardcoding it, so it also handles the draft Rename mdx-reference-docs.zip to reference-docs.zip bazel#31269 (mdx-reference-docs.zip→reference-docs.zip). The uploaded artifact path stays underbazel-bin/as before.Merge order: this should be merged, and the
gcr.io/bazel-public/mintlifyimage rebuilt, before bazelbuild/bazel#31268 merges.Testing
I ran the new selection logic against three Bazel checkouts:
master(before rename)gen_mdx_reference_docsmdx-reference-docs.zipgen_reference_docsmdx-reference-docs.zipgen_reference_docsreference-docs.zipI haven't run it inside the Docker image or on Buildkite.
Related PRs
Issue: bazelbuild/bazel#31211
gen_mdx_reference_docs→gen_reference_docsmdx-reference-docs.zip→reference-docs.zip(draft)The bazel-docs and continuous-integration PRs accept both the old and new names. The bazel-docs PRs can merge in any order.
🤖 Generated with Claude Code