Skip to content

build(release): search for rules_python in BCR PR query #4238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rickeylev merged 1 commit into from
Oct 10, 2026
+2 −4
Merged

build(release): search for rules_python in BCR PR query #4238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions dev/release/promote.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,9 +184,7 @@ def run(self) -> int:
branch_url = f"{REPO_URL}/tree/{branch_name}"
release_url = f"{REPO_URL}/releases/tag/{version}"
bcr_entry_url = f"https://registry.bazel.build/modules/rules_python/{version}"
bcr_query = (
f'is:pr ("bazel-contrib/rules_python" in:title) ("@{version}" in:title)'
)
bcr_query = f'is:pr ("rules_python" in:title) ("@{version}" in:title)'
bcr_search_url = f"https://github.com/bazelbuild/bazel-central-registry/pulls?q={urllib.parse.quote(bcr_query)}"

if run_id := os.environ.get("GITHUB_RUN_ID"):
Expand Down
2 changes: 1 addition & 1 deletion tests/tools/private/release/promote_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def test_promote_rc_success(mock_git, mock_gh):
"Version **2.0.0** has been successfully generated and tagged on branch [`release/2.0`](https://github.com/bazel-contrib/rules_python/tree/release/2.0).\n\n"
"- [Github Release 2.0.0](https://github.com/bazel-contrib/rules_python/releases/tag/2.0.0)\n"
"- [BCR Entry 2.0.0](https://registry.bazel.build/modules/rules_python/2.0.0)\n"
"- [BCR PRs](https://github.com/bazelbuild/bazel-central-registry/pulls?q=is%3Apr%20%28%22bazel-contrib/rules_python%22%20in%3Atitle%29%20%28%22%402.0.0%22%20in%3Atitle%29)\n"
"- [BCR PRs](https://github.com/bazelbuild/bazel-central-registry/pulls?q=is%3Apr%20%28%22rules_python%22%20in%3Atitle%29%20%28%22%402.0.0%22%20in%3Atitle%29)\n"
"- [Release workflow status](https://github.com/bazel-contrib/rules_python/actions/workflows/release_promote.yaml)"
)
assert mock_gh.issue_comments[issue_num] == [expected_comment]
Expand Down
Loading