Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
7 tasks
Greptile SummaryThis PR establishes composition compatibility references ahead of alpha changes.
Confidence Score: 4/5The PR appears safe to merge, with a non-blocking gap in the claimed editor-hydration regression coverage. The rendering baselines and CI integration are coherent, but the default-project check validates a viewer snapshot rather than the production editor-store hydration path. Files Needing Attention: tests/composition/browser.mjs Prompt To Fix All With AI### Issue 1
tests/composition/browser.mjs:220
**Hydration path is untested**
This calls `buildViewerProjectState`, which creates a read-only snapshot rather than exercising `applyLabProjectFile`, the actual editor hydration path. Regressions in restoring stores, pruning timeline tracks, applying scene settings, or signaling scene replacement could therefore pass this compatibility check. Please test the real hydration entry point and assert the resulting store state.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (1): Last reviewed commit: "test: establish V3 composition and alpha..." | Re-trigger Greptile |
This was referenced Sep 17, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
V3 alpha changes will affect a compositor shared by sources and effects, and existing masks currently darken RGB instead of cutting transparent holes. This PR establishes compatibility references before changing those semantics.
Part of parent #150. Base:
git-chad/shader-lab-v3-plan, notmain. This is the first slice of roadmap steps 1.1–1.2; it does not complete phase 1 or change rendering behavior.tests/composition/README.md.Validation:
bun run test:composition,bun run check(passes with three existing warnings), andbunx changeset status --since=origin/git-chad/shader-lab-v3-planpass locally. A deliberate expected-pixel mutation was also rejected by the suite. The suite explicitly selects WebGPU through SwiftShader; missing GPU support and browser/shader errors fail rather than skip.GPU CI runs in a dedicated
macos-14job with PNG artifacts. Linux retains build/lint/type checks: its Chromium/SwiftShader drops the GPU instance during texture-backed shader compilation, so Linux GPU execution is not yet supported. No baseline tolerances or assertions were relaxed.Limits: the four visual fixtures are synthetic regression scenes. The fourteen artistic references and broader photographic/video baselines are still outstanding. The real default project receives persistence checks only, and full runtime scene/export parity, groups, masks, and undo coverage remain future slices.