V3: transparent borders for newly contained media - #152
Merged
git-chad merged 7 commits intoOct 1, 2026
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
7 tasks
Greptile SummaryThis PR adds opt-in transparent borders for contained image and video layers while preserving opaque borders for legacy projects and runtime configurations.
Confidence Score: 5/5The PR appears safe to merge with no actionable correctness, security, or repository-rule violations identified. Transparent bounds compose correctly in both renderers, absent values preserve compatibility, new layers receive the intended default, and persistence and export paths retain explicit values. Reviews (1): Last reviewed commit: "fix: reveal lower content around newly c..." | Re-trigger Greptile |
git-chad
changed the base branch from
git-chad/v3-composition-alpha
to
git-chad/shader-lab-v3-plan
October 1, 2026 15:12
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New image and video layers in Contain mode now reveal lower content at their empty borders instead of painting black bars. A Transparent Borders toggle, shown for Contain mode, restores black borders when disabled. Cover mode is unchanged.
Saved projects without the setting are normalized to
transparentBounds: falsebefore applying new defaults. Existing exported runtime configs also retain black borders when the setting is absent. Both editor and runtime MediaPass use the same opt-in alpha behavior; shader export preserves the setting.Stack: this PR targets
git-chad/v3-composition-alpha(#151), which targetsgit-chad/shader-lab-v3-plan(parent #150). Nothing in the stack targetsmainexcept the draft parent PR. The roadmap and CI branch filters now support this workflow.Validation:
bun run test:composition: all legacy PNG baselines and 136 editor/runtime blend samples pass unchanged; added GPU coverage for image/video borders, opacity, scale/offset, Cover behavior, migration, save/reopen, shader export, and PNG export.bun run check, runtime typecheck, and MCP typecheck pass (three pre-existing app lint warnings).This is a bounded first fix in roadmap step 1.2. It does not implement transparent scene/export backgrounds, isolated groups, or new mask semantics.
Manual preview check: