Skip to content

Make select's offset the 0-based position of the first match #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
awolverp merged 1 commit into from
Oct 7, 2026
Merged

Make select's offset the 0-based position of the first match #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/docs/querying.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,10 @@ for element in tree.select("[class^=par-]"):
# Element(name=QualName(local="p", ns="http://www.w3.org/1999/xhtml", prefix=None), attrs=[(QualName(local="class"), "par-one")], template=false, integration_point=false)
# Element(name=QualName(local="p", ns="http://www.w3.org/1999/xhtml", prefix=None), attrs=[(QualName(local="class"), "par-two")], template=false, integration_point=false)

print(tree.select_one("p", offset=3))
print(tree.select_one("p", offset=2))
# Element(name=QualName(local="p", ns="http://www.w3.org/1999/xhtml", prefix=None), attrs=[(QualName(local="class"), "end-par")], template=false, integration_point=false)

for element in tree.select("[class*=par]", offset=3, limit=1):
for element in tree.select("[class*=par]", offset=2, limit=1):
print(element)
# Element(name=QualName(local="p", ns="http://www.w3.org/1999/xhtml", prefix=None), attrs=[(QualName(local="class"), "end-par")], template=false, integration_point=false)
```
Expand Down
2 changes: 1 addition & 1 deletion python/markupever/iterators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ def __init__(
self.__raw = iter(_rustlib.Select(value._raw, expr))

self.__limit = limit or -1
self.__offset = offset - 1
self.__offset = offset

def __iter__(self):
return self
Expand Down
11 changes: 10 additions & 1 deletion python/tests/test_dom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,14 +333,23 @@ def test_select():
assert count == 1

count = 0
for tag in dom.select("p", offset=3):
for tag in dom.select("p", offset=2):
count += 1
assert isinstance(tag, markupever.dom.Element)
assert tag.name == "p"
assert tag.id is None

assert count == 1

# offset is the 0-based position of the first match.
assert [tag.id for tag in dom.select("p", offset=0)] == ["title", "text", None]
assert [tag.id for tag in dom.select("p", offset=1)] == ["text", None]
assert [tag.id for tag in dom.select("p", offset=1, limit=1)] == ["text"]
assert list(dom.select("p", offset=3)) == []
assert dom.select_one("p", offset=0).id == "title"
assert dom.select_one("p", offset=1).id == "text"
assert dom.select_one("p", offset=3) is None

tag = dom.select_one("nav.nav2")
assert tag.name == "nav"
assert tag.class_list == ["nav2"]
Expand Down
Loading