Repository navigation
Make select's offset the 0-based position of the first match - #27
Merged
Merged
Conversation
select() and select_one() documented offset as the number of initial matches to skip, but treated it as the 1-based position of the first match: offset=0 and offset=1 both started at the first match, and offset=2 skipped only one. Skip offset matches, so that offset is the 0-based position of the first match, as documented. Update the examples in the documentation, which relied on the old behavior. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Anders Kaseorg <andersk@mit.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
select()andselect_one()documentedoffsetas the number of initial matches to skip, but treated it as the 1-based position of the first match:offset=0andoffset=1both started at the first match, andoffset=2skipped only one.Skip
offsetmatches, so that offset is the 0-based position of the first match, as documented. Update the examples in the documentation, which relied on the old behavior.