Repository navigation
ESP/Speaker: Reduce amplifier and playback buffer allocations - #165
Merged
ao-david merged 2 commits intoOct 29, 2026
Merged
Conversation
Store the I2S channel handle by value instead of allocating a wrapper on the heap. The channel is now released with i2s_del_channel() in the TAS5805 destructor, and copying the amplifier is explicitly disabled to prevent double frees.
Allocate the file, staging, and I2S buffers lazily on the first playback pass and keep them for the lifetime of the amplifier. This removes the repeated allocation and freeing of large blocks that occurred every time play() was called. The buffers are released by the destructor. Unsupported WAV layouts are now rejected before reading, since the file buffer is sized for at most two channels.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #164.
TAS5805::play()#158).