Repository navigation
ESP/Netsender: Remove dynamic allocation from HTTP request paths - #166
Merged
ao-david merged 2 commits intoOct 29, 2026
Merged
Conversation
Replace netsender_extract_json's std::string interface with a bounded (const char *) API that writes into caller-provided buffers. Response fields are now parsed directly from the fixed HTTP response buffer, so the poll/vars/config paths no longer allocate temporary strings. Remove std::string from the variable state helpers in favour of std::string_view and fixed character buffers, and replace std::stoi with non-throwing parsing. Update gen_vars.py so regenerated headers keep the allocation-free behaviour.
The pin readers and variable parser are intentionally non-capturing functions, so store them as plain function pointers instead of std::function. Convert the logging reader from a lambda to a static function as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #165.
std::functioncallbacks where callbacks are intentionally function pointers #160).