Repository navigation
ESP/Speaker: Fix NetSender response handling and amplifier defaults - #164
Merged
Merged
Conversation
- Correct operator precedence in HTTP status checks so the actual status code is compared and logged in config and poll requests. - Log char-array config fields with %s instead of %d. - Default the amplifier I2C clock to a value inside the Kconfig range, avoiding the previous clamp warning at build time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes several correctness issues found while reviewing the speaker NetSender code:
%sinstead of%d.This is the base of the speaker hardening stack.