Skip to content

fix(codex-plugin): name deploy skills after their directories - #2086

Merged
ChiragAgg5k merged 2 commits into
mainfrom
fix/codex-deploy-skill-names
Oct 17, 2026
Merged

ChiragAgg5k merged 2 commits into
mainfrom
fix/codex-deploy-skill-names

Conversation

@ChiragAgg5k

@ChiragAgg5k ChiragAgg5k commented Oct 17, 2026 •

Copy link
Copy Markdown
Member

What does this PR do?

The Codex plugin emits the shared deploy templates (templates/plugin/commands/deploy-*.md.twig) as skills at plugins/appwrite/skills/appwrite-deploy-site/SKILL.md and .../appwrite-deploy-function/SKILL.md, but their frontmatter name was deploy-site / deploy-function. The Agent Skills specification requires the name field to match the parent directory name.

For CodexPlugin the frontmatter name now goes through the existing skillName filter, giving appwrite-deploy-site / appwrite-deploy-function, the same prefix the generated language skills already use.

The Claude and Cursor plugins render the same templates as slash commands (commands/deploy-site.md, commands/deploy-function.md), where the command is named by its file, so their output is unchanged. Every other generated SKILL.md (skills, Claude, Cursor, Codex language skills) already matched its directory.

Test Plan

  • New Generation test testSkillNamesMatchTheirDirectories with a SKILL_LANGUAGES table (skills, claude-plugin, cursor-plugin, codex-plugin) asserting every generated SKILL.md frontmatter name equals its directory name.
    • Red without the template change: codex-plugin fails with 'appwrite-deploy-function' expected, 'deploy-function' actual.
    • Green with it; the full Generation suite passes (114 tests).
  • Regenerated codex-plugin, claude-plugin, cursor-plugin, skills and zed-extension; all 46 generated SKILL.md files match their directories, and the Claude/Cursor commands still read name: deploy-site / name: deploy-function.
  • claude plugin validate examples/claude-plugin passes.
  • composer lint, composer refactor:check, composer lint-twig and the twig max-line-length check pass.

Related PRs and Issues

None.

Closes #2087

The Agent Skills spec requires a skill's frontmatter name to match its parent directory. The Codex plugin ships the deploy commands as skills under appwrite-deploy-site and appwrite-deploy-function, but kept the bare command names, so spec-conforming loaders reject or misname them. Claude and Cursor still emit these templates as commands named by file, so their names stay unchanged.
@hansi-codes

hansi-codes Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

🟢 Tier S · Ready to merge

The Codex-only naming change matches the existing skill-name convention, and the new generation test covers all targets that emit skills.

Updated the shared deploy-site and deploy-function templates to use the skill-name filter for Codex-generated skills while preserving command names for Claude and Cursor. Added generation coverage that checks each generated SKILL.md name against its containing directory across the four skill targets.

Verdict New comments Fixed Still open
✅ Approved 0 0 0
📂 Walkthrough · 3
File Change
templates/plugin/commands/deploy-function.md.twig Prefixes the Codex deploy-function skill name to match its directory; leaves other plugin command names unchanged.
templates/plugin/commands/deploy-site.md.twig Prefixes the Codex deploy-site skill name to match its directory; leaves other plugin command names unchanged.
tests/generation/GenerationTest.php Adds skills plugin targets to generation setup and asserts generated skill frontmatter names match their directories.

Merged main (49681d1); no changes to this PR's code since 42e08cf · Details · Comment @hansi-codes review to re-run, or mention @hansi-codes with a question.

@hansi-codes hansi-codes Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Tier S · Looks good to merge. Summary

…l-names

# Conflicts:
#	tests/generation/GenerationTest.php
@ChiragAgg5k
ChiragAgg5k merged commit 3dce285 into main Oct 17, 2026
61 checks passed
@ChiragAgg5k
ChiragAgg5k deleted the fix/codex-deploy-skill-names branch October 17, 2026 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Name the Codex plugin's deploy skills after their directories

1 participant