Skip to content

fix: fail update-images when values.yaml can't be read #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
levivannoort merged 1 commit into from
Oct 14, 2026
Merged

fix: fail update-images when values.yaml can't be read #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions hack/update-images.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,14 @@ newest() {

escape() { sed 's/[][\.*^$+?(){}|/]/\\&/g' <<<"$1"; }

# Read before the loop rather than through process substitution, whose exit
# status set -e doesn't see: a values.yaml yq can't parse must fail the run.
images=$(yq -r '.. | select(tag == "!!map" and has("registry") and has("repository") and .tag != "")
| [(path | map(tostring) | join(".")), .registry, .repository, .tag] | @tsv' "$VALUES")

changed=0
while IFS=$'\t' read -r path registry repository tag; do
[[ -n "$path" ]] || continue # the here-string's line when there are no images
if [[ "$all" == false ]] && grep -qx "${registry}/${repository}" <<<"$appwrite_group"; then
printf ' %-45s %s (follows Appwrite %s, --all to update)\n' "${registry}/${repository}" "$tag" \
"$(yq '.appVersion' "$CHART/Chart.yaml")"
Expand All @@ -106,8 +112,7 @@ while IFS=$'\t' read -r path registry repository tag; do
{ print }
' "$VALUES" > "$VALUES.tmp" && mv "$VALUES.tmp" "$VALUES"
fi
done < <(yq -r '.. | select(tag == "!!map" and has("registry") and has("repository") and .tag != "")
| [(path | map(tostring) | join(".")), .registry, .repository, .tag] | @tsv' "$VALUES")
done <<<"$images"

if [[ "$changed" -gt 0 && "$dry_run" == false ]]; then
"$(dirname "$0")/chart-images.sh"
Expand Down