Skip to content

fix: fail update-images when values.yaml can't be read - #19

Merged
levivannoort merged 1 commit into
mainfrom
fix/update-images-errors
Oct 14, 2026
Merged

levivannoort merged 1 commit into
mainfrom
fix/update-images-errors

Conversation

@levivannoort

Copy link
Copy Markdown
Member

What

Follow-up to #17 for hansi-codes' finding (thread), pushed after #17 was merged.

hack/update-images.sh read the image list from yq through process substitution (done < <(yq …)), whose exit status set -e doesn't see. With yq missing or values.yaml unparseable, it printed an error and exited 0, like a run with nothing to update. It now reads the list into a variable first, and skips the empty line the here-string gives when there are no images.

Only hack/ changes, so no changelog entry.

Testing

  • shellcheck -S warning is clean.
  • Unparseable values.yaml: exits 1 (exited 0 before).
  • values.yaml without images: exits 0 and prints nothing.
  • Real values.yaml: --dry-run lists the same 15 images as before.

Checklist

  • make test passes locally (no chart changes)
  • Unit tests: not applicable (helper script)

The image list came from yq through process substitution, whose exit status
set -e doesn't see: a missing yq or an unparseable values.yaml printed an
error and exited 0, like a run with nothing to update. Read it into a
variable first.
@hansi-codes

hansi-codes Bot commented Oct 14, 2026

Copy link
Copy Markdown

🟢 Tier S · Ready to merge

The image updater now captures the yq image list before processing it, so read or parse failures propagate to the script's exit status. It also skips the empty here-string line when there are no images to update.

Verdict New comments Fixed Still open
✅ Approved 0 0 0
📂 Walkthrough · 1
File Change
hack/update-images.sh Capture the image list before the loop and ignore the empty-input line.

Reviewed a88ece0 · Details · Comment @hansi-codes review to re-run, or mention @hansi-codes with a question.

@hansi-codes hansi-codes Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Tier S · Looks good to merge. Summary

@levivannoort
levivannoort merged commit e7346a4 into main Oct 14, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant