Repository navigation
fix: fail update-images when values.yaml can't be read - #19
Merged
Merged
Conversation
The image list came from yq through process substitution, whose exit status set -e doesn't see: a missing yq or an unparseable values.yaml printed an error and exited 0, like a run with nothing to update. Read it into a variable first.
🟢 Tier S · Ready to mergeThe image updater now captures the
📂 Walkthrough · 1
Reviewed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #17 for hansi-codes' finding (thread), pushed after #17 was merged.
hack/update-images.shread the image list fromyqthrough process substitution (done < <(yq …)), whose exit statusset -edoesn't see. Withyqmissing orvalues.yamlunparseable, it printed an error and exited 0, like a run with nothing to update. It now reads the list into a variable first, and skips the empty line the here-string gives when there are no images.Only
hack/changes, so no changelog entry.Testing
shellcheck -S warningis clean.values.yaml: exits 1 (exited 0 before).values.yamlwithout images: exits 0 and prints nothing.values.yaml:--dry-runlists the same 15 images as before.Checklist
make testpasses locally (no chart changes)