Skip to content

SOLR-18360: un-deprecate HttpJettySolrClient.addListenerFactory #4780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
serhiy-bzhezytskyy wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −2
Open

SOLR-18360: un-deprecate HttpJettySolrClient.addListenerFactory #4780

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion solr/core/src/java/org/apache/solr/handler/component/HttpShardHandlerFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,8 +309,8 @@ public void init(PluginInfo info) {
.withIdleTimeout(soTimeout, TimeUnit.MILLISECONDS)
.withExecutor(commExecutor)
.withMaxConnectionsPerHost(maxConnectionsPerHost)
.addListenerFactory(this.httpListenerFactory)
.build();
this.defaultClient.addListenerFactory(this.httpListenerFactory);
this.loadbalancer = new LBJettySolrClient.Builder(defaultClient).build();

initReplicaListTransformers(getParameter(args, "replicaRouting", null, sb));
Expand Down
8 changes: 7 additions & 1 deletion solr/solrj-jetty/src/java/org/apache/solr/client/solrj/jetty/HttpJettySolrClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,13 @@ private void applyClientCustomizer() {
}
}

@Deprecated(since = "9.7")
/**
* Registers a listener factory on an already-built client, without discarding it. Prefer {@link
* Builder#addListenerFactory} when constructing a new client; this instance method exists for the
* case where the listener isn't known yet at construction time (or may need to change later), and
* this client's identity may already be relied on elsewhere, so it can't simply be rebuilt and
* swapped out.
*/
public void addListenerFactory(HttpListenerFactory factory) {
this.listenerFactory.add(factory);
}
Expand Down