SOLR-18360: un-deprecate HttpJettySolrClient.addListenerFactory - #4780
Open
serhiy-bzhezytskyy wants to merge 1 commit into
Open
SOLR-18360: un-deprecate HttpJettySolrClient.addListenerFactory#4780serhiy-bzhezytskyy wants to merge 1 commit into
serhiy-bzhezytskyy wants to merge 1 commit into
Conversation
…istenerFactory) The ticket asked to remove this instance method in favor of the Builder-only equivalent, but PKIAuthenticationPlugin (implementing HttpClientBuilderPlugin) attaches a listener to already-built clients across HttpShardHandlerFactory/UpdateShardHandler/HttpSolrClientProvider from CoreContainer.setupHttpClientForAuthPlugin -- a path that can re-fire on security.json hot-reload, on clients that other long-lived objects (e.g. HttpShardHandlerFactory's own loadbalancer) already reference. Rebuilding via the Builder instead would desync those references. Migrated the one call site that WAS just construction-time convenience (HttpShardHandlerFactory's own defaultClient) to the Builder method; left the instance method for the case it actually serves.
Contributor
Author
|
@epugh flagging this un-deprecation (not a removal) -- see PR description for why the instance method is still needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-18360
Un-deprecates
HttpJettySolrClient.addListenerFactory(HttpListenerFactory)instead of removing it.PKIAuthenticationPluginneeds it to attach a listener to clients that are already built and already referenced elsewhere by the time security wiring runs:Rebuilding
defaultClientvia the Builder instead would leaveloadbalancerpointing at the old, listener-less client -- the security listener would silently never fire on the path that actually routes inter-node requests.Migrated the one call site that was pure construction-time convenience (
HttpShardHandlerFactory's owndefaultClient) toBuilder.addListenerFactory. No changelog (un-deprecation, not a removal).50 tests, 0 failures.
AI-assisted (Claude Sonnet 5)