Skip to content

refactor: reduce CollectionService internal method visibility #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adityamparikh wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

refactor: reduce CollectionService internal method visibility #103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/main/java/org/apache/solr/mcp/server/collection/CollectionService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,7 +573,7 @@ public SolrMetrics getCollectionStats(
* @see IndexStats
* @see LukeResponse
*/
public IndexStats buildIndexStats(LukeResponse lukeResponse) {
IndexStats buildIndexStats(LukeResponse lukeResponse) {
NamedList<Object> indexInfo = lukeResponse.getIndexInfo();

// Extract index information using helper methods
Expand Down Expand Up @@ -614,7 +614,7 @@ public IndexStats buildIndexStats(LukeResponse lukeResponse) {
* @see QueryStats
* @see QueryResponse
*/
public QueryStats buildQueryStats(QueryResponse response) {
QueryStats buildQueryStats(QueryResponse response) {

return new QueryStats(response.getQTime(), response.getResults().getNumFound(),
response.getResults().getStart(), response.getResults().getMaxScore());
Expand Down Expand Up @@ -669,7 +669,7 @@ public QueryStats buildQueryStats(QueryResponse response) {
* @see #extractCacheStats(NamedList)
* @see #isCacheStatsEmpty(CacheStats)
*/
public @Nullable CacheStats getCacheMetrics(String collection) throws SolrServerException, IOException {
@Nullable CacheStats getCacheMetrics(String collection) throws SolrServerException, IOException {
String actualCollection = extractCollectionName(collection);

if (!validateCollectionExists(actualCollection)) {
Expand Down Expand Up @@ -785,7 +785,7 @@ private CacheStats extractCacheStats(NamedList<Object> coreMetrics) {
* @see #fetchFlatHandlerInfo(String, String, String)
* @see #isHandlerStatsEmpty(HandlerStats)
*/
public @Nullable HandlerStats getHandlerMetrics(String collection) throws SolrServerException, IOException {
@Nullable HandlerStats getHandlerMetrics(String collection) throws SolrServerException, IOException {
String actualCollection = extractCollectionName(collection);

if (!validateCollectionExists(actualCollection)) {
Expand Down