refactor: reduce CollectionService internal method visibility - #103
Open
adityamparikh wants to merge 1 commit into
Open
refactor: reduce CollectionService internal method visibility#103adityamparikh wants to merge 1 commit into
adityamparikh wants to merge 1 commit into
Conversation
adityamparikh
force-pushed
the
refactor/collection-service-visibility
branch
from
May 2, 2026 17:04
fa55fbb to
29ab01a
Compare
adityamparikh
force-pushed
the
refactor/collection-service-visibility
branch
from
June 14, 2026 03:36
29ab01a to
dacb439
Compare
…lity Change buildIndexStats(), buildQueryStats(), getCacheMetrics(), and getHandlerMetrics() from public to package-private. These are internal implementation details not called outside the collection package. Closes #17 Signed-off-by: Aditya Parikh <aditya.m.parikh@gmail.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: adityamparikh <aditya.m.parikh@gmail.com>
adityamparikh
force-pushed
the
refactor/collection-service-visibility
branch
from
August 19, 2026 11:58
dacb439 to
cd3afee
Compare
Contributor
Author
|
Rebased onto Conflict resolution: I also re-checked that the narrowing is actually safe: every caller of all four methods — Verified: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildIndexStats(),buildQueryStats(),getCacheMetrics(),getHandlerMetrics()from public to package-privateTest plan
./gradlew buildpasses./gradlew nativeTest -Pnativepasses (119/119 tests)🤖 Generated with Claude Code