Skip to content

RATIS-2803. Change GrpcLogAppender.appendEntriesIndex to volatile and drop the readlock #1684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amaliujia merged 1 commit into from
Nov 5, 2026
+2 −4
Merged

RATIS-2803. Change GrpcLogAppender.appendEntriesIndex to volatile and drop the readlock #1684

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions ratis-grpc/src/main/java/org/apache/ratis/grpc/server/GrpcLogAppender.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ synchronized int process(Event event) {
@SuppressWarnings({"squid:S3077"}) // Suppress volatile for generic type
private volatile StreamObservers appendLogRequestObserver;
// the appendEntries channel of this appender, taken when it creates its first stream; guarded by the write lock
private int appendEntriesIndex = -1;
private volatile int appendEntriesIndex = -1;
private final boolean useSeparateHBChannel;

private final GrpcServerMetrics grpcServerMetrics;
Expand Down Expand Up @@ -427,9 +427,7 @@ void onCompleted() {

@VisibleForTesting
int getAppendEntriesIndex() {
try (AutoCloseableLock readLock = lock.readLock(caller, LOG::trace)) {
return appendEntriesIndex;
}
return appendEntriesIndex;
}

@Override
Expand Down
Loading