Repository navigation
RATIS-2803. Change GrpcLogAppender.appendEntriesIndex to volatile and drop the readlock - #1684
Merged
Merged
Conversation
Contributor
Author
|
@yandrey321 after taking a second look, it seems to me that we can simplify the code a bit. |
yandrey321
approved these changes
Nov 5, 2026
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Change
GrpcLogAppender.appendEntriesIndextovolatileand drop the readlock.We can do it because the
getteris only used in testing, and the testing only needs to see the latest written complete value.This will make the code cleaner.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-2803
How was this patch tested?
Existing tests